Skip to content

Instrument ESP32 framework library build tail#179

Merged
zackees merged 1 commit intomainfrom
fix/117-esp32-tail-instrumentation
Apr 22, 2026
Merged

Instrument ESP32 framework library build tail#179
zackees merged 1 commit intomainfrom
fix/117-esp32-tail-instrumentation

Conversation

@zackees
Copy link
Copy Markdown
Member

@zackees zackees commented Apr 22, 2026

Summary

  • Emit immediate FBUILD_PERF_LOG phase-start/phase-finish events with wall-clock and last_phase labels.
  • Add ESP32 tail checkpoints around framework built-in library compilation, source scanning, compile phases, link/convert/size, boot artifacts, and fingerprint save.
  • Log archive start in library compilation so a stall after the last compile [lib] line can be distinguished from archive or orchestrator handoff.

Closes #117.

Tests

  • uv run cargo fmt --all
  • uv run soldr cargo check -p fbuild-build -p fbuild-packages
  • git diff --check

Caveat

  • uv run soldr cargo test -p fbuild-build perf_log --lib was attempted, but the host ran out of disk space while compiling dependencies (rustc-LLVM ERROR: IO failure on output stream: no space on device) before reaching the crate tests.

@coderabbitai
Copy link
Copy Markdown

coderabbitai Bot commented Apr 22, 2026

Warning

Rate limit exceeded

@zackees has exceeded the limit for the number of commits that can be reviewed per hour. Please wait 29 minutes and 22 seconds before requesting another review.

Your organization is not enrolled in usage-based pricing. Contact your admin to enable usage-based pricing to continue reviews beyond the rate limit, or try again in 29 minutes and 22 seconds.

⌛ How to resolve this issue?

After the wait time has elapsed, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

We recommend that you space out your commits to avoid hitting the rate limit.

🚦 How do rate limits work?

CodeRabbit enforces hourly rate limits for each developer per organization.

Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout.

Please see our FAQ for further information.

ℹ️ Review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

Run ID: 95fe0925-cae6-4c1f-80bd-d4cb5ee1a65b

📥 Commits

Reviewing files that changed from the base of the PR and between 58671cd and ea6b2d4.

📒 Files selected for processing (3)
  • crates/fbuild-build/src/esp32/orchestrator.rs
  • crates/fbuild-build/src/perf_log.rs
  • crates/fbuild-packages/src/library/library_compiler.rs
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch fix/117-esp32-tail-instrumentation

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@zackees zackees merged commit 80735ba into main Apr 22, 2026
77 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

perf: ESP32 cold-build stalls mid-framework-lib compile (no active compilers)

1 participant