Skip to content

Avoid duplicate native release builds #187

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
zackees merged 1 commit into from
Apr 22, 2026
Merged

Avoid duplicate native release builds #187

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
20 changes: 13 additions & 7 deletions .github/workflows/template_native_build.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -89,11 +89,13 @@ jobs:
shell: bash
run: |
if [ "${{ inputs.linux_cross }}" = "true" ]; then
soldr cargo zigbuild --release --target ${{ inputs.target }} -p fbuild-cli
soldr cargo zigbuild --release --target ${{ inputs.target }} -p fbuild-daemon
soldr cargo zigbuild --release --target ${{ inputs.target }} \
-p fbuild-cli \
-p fbuild-daemon
else
soldr cargo build --release --target ${{ inputs.target }} -p fbuild-cli
soldr cargo build --release --target ${{ inputs.target }} -p fbuild-daemon
soldr cargo build --release --target ${{ inputs.target }} \
-p fbuild-cli \
-p fbuild-daemon
fi

# PyO3 extension — built for ALL targets, including cross-compiled.
Expand Down Expand Up @@ -124,9 +126,13 @@ jobs:
--target ${{ inputs.target }} -p fbuild-python \
--features extension-module
elif [ "${{ runner.os }}" = "macOS" ]; then
soldr cargo build --release -p fbuild-python --features extension-module
soldr cargo build --release --target ${{ inputs.target }} \
-p fbuild-python \
--features extension-module
else
soldr cargo build --release -p fbuild-python --features extension-module
soldr cargo build --release --target ${{ inputs.target }} \
-p fbuild-python \
--features extension-module
fi

- name: Stage artifacts
Expand All @@ -142,7 +148,7 @@ jobs:
ARCH="${TARGET%%-*}"
ext_src="target/${ARCH}-unknown-linux-gnu/release/lib_native.so"
[ -f "$ext_src" ] && cp "$ext_src" staging/_native.abi3.so
elif [ "${{ inputs.macos_cross }}" = "true" ]; then
elif [ "${{ runner.os }}" = "macOS" ]; then
ext_src="target/${{ inputs.target }}/release/lib_native.dylib"
[ -f "$ext_src" ] && cp "$ext_src" staging/_native.abi3.so
elif [ "${{ inputs.binary_ext }}" = ".exe" ]; then
Expand Down
Loading