Skip to content

teensy: prefer local FastLED over framework FastLED#198

Merged
zackees merged 1 commit intomainfrom
codex/issue-195-teensy30-fastled-shadow
Apr 24, 2026
Merged

teensy: prefer local FastLED over framework FastLED#198
zackees merged 1 commit intomainfrom
codex/issue-195-teensy30-fastled-shadow

Conversation

@zackees
Copy link
Copy Markdown
Member

@zackees zackees commented Apr 24, 2026

Summary

  • fix the Teensy framework-library auto-selection bug that was compiling bundled libraries/FastLED even when the project already provided a local lib/FastLED
  • make the resolver prefer project-local headers in src/, include/, and lib/ over bundled framework headers with the same basename, while still allowing transitive framework dependencies like SPI.h
  • add unit and ignored teensy30 integration regression coverage for the local lib/FastLED shadowing path

Root Cause

This was not an SPI.h header conflict.

The failure came from the Teensy framework-library selector building a basename map of bundled framework headers and treating the sketch's #include <FastLED.h> as a request to compile the bundled framework FastLED library, even when the project already had its own lib/FastLED/FastLED.h.

That caused two independent build paths to compile FastLED into the same link:

  • project-local library compilation from lib/FastLED/...
  • bundled framework-library compilation from framework-arduinoteensy/.../libraries/FastLED/...

SPI.h only shows up as a legitimate transitive dependency after local FastLED is selected.

Testing

  • cargo test -p fbuild-build resolve_teensy_framework_libraries -- --nocapture
  • cargo test -p fbuild-build --test teensy_build build_teensy30_fixture_prefers_local_fastled -- --ignored --nocapture

Fixes #199.
Closes #195.

@coderabbitai
Copy link
Copy Markdown

coderabbitai Bot commented Apr 24, 2026

Warning

Rate limit exceeded

@zackees has exceeded the limit for the number of commits that can be reviewed per hour. Please wait 59 minutes and 14 seconds before requesting another review.

Your organization is not enrolled in usage-based pricing. Contact your admin to enable usage-based pricing to continue reviews beyond the rate limit, or try again in 59 minutes and 14 seconds.

⌛ How to resolve this issue?

After the wait time has elapsed, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

We recommend that you space out your commits to avoid hitting the rate limit.

🚦 How do rate limits work?

CodeRabbit enforces hourly rate limits for each developer per organization.

Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout.

Please see our FAQ for further information.

ℹ️ Review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

Run ID: 9f14cad5-72d9-4c6f-95ba-a08a8b476cf4

📥 Commits

Reviewing files that changed from the base of the PR and between 3cc09b8 and e1fe476.

📒 Files selected for processing (2)
  • crates/fbuild-build/src/teensy/orchestrator.rs
  • crates/fbuild-build/tests/teensy_build.rs
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch codex/issue-195-teensy30-fastled-shadow

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@zackees zackees changed the title teensy: guard local FastLED shadowing on teensy30 teensy: prefer local FastLED over framework FastLED Apr 24, 2026
@zackees zackees merged commit 37b327c into main Apr 24, 2026
77 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

1 participant