feat(test-matrix): #224 add SuperMini, nice!nano, nRFMicro nRF52840 boards#225
Merged
Conversation
…oards Mirrors FastLED PR FastLED/FastLED#2445 by extending fbuild's regression matrix to cover the three pdcook/nRFMicro-Arduino-Core community boards. Each test platform reuses the nrf52840_dk_adafruit PlatformIO board (no first-party board package exists for these community variants) and sets the matching -DTARGET_* build flag so the FastLED variant code path is exercised in CI. Adds three workflows and Nordic NRF52 README badges. Closes #224 Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
|
Caution Review failedThe pull request is closed. ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (17)
📝 WalkthroughWalkthroughThis PR extends the fbuild test matrix with support for three nRF52840 community boards: SuperMini, nice!nano v2, and nRFMicro. Each board receives a GitHub Actions workflow, PlatformIO configuration with variant-specific build flags, a minimal LED-blink test sketch, and documentation explaining the setup and variant code path coverage. ChangesnRF52840 Community Boards Test Support
Estimated code review effort🎯 2 (Simple) | ⏱️ ~10 minutes Possibly related PRs
Poem
✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #224
Summary
Extends fbuild's self-test matrix with three nRF52840 community boards from the pdcook/nRFMicro-Arduino-Core BSP, mirroring FastLED PR FastLED/FastLED#2445:
supermini_nrf52840→ SuperMini nRF52840nice_nano_nrf52840→ nice!nano v2 (ProMicro-pin-compatible footprint)nrfmicro_nrf52840→ nRFMicroApproach
Each test platform reuses the existing
nrf52840_dk_adafruitPlatformIO board (no first-party board package exists for these community variants — the same approach FastLED takes viareal_board_name="nrf52840_dk_adafruit"inci/boards.py). The matching-DTARGET_*build flag selects the variant block so the FastLED code path is exercised when these boards are compiled in CI.No new board JSONs were added because all three boards share
nrf52840_dk_adafruit's build settings; only theTARGET_*define differs.Files
tests/platform/{supermini,nice_nano,nrfmicro}_nrf52840/{platformio.ini, README.md, src/main.ino, src/README.md}— minimal blink sketches.github/workflows/build-{supermini,nice_nano,nrfmicro}_nrf52840.yml— per-board workflows callingtemplate_build.ymlREADME.md— three new badges in the Nordic NRF52 grouptests/platform/README.md— three rows in the platform tableTest plan
template_build.ymlARDUINO_BSP_VERSIONparsing failure with GCC 15.2.1), follow up with a BSP package pin🤖 Generated with Claude Code
Summary by CodeRabbit
Release Notes
New Features
Tests
Chores
Documentation