fix(esp32c6): add missing build.variant to esp32-c6-devkitc-1#47
fix(esp32c6): add missing build.variant to esp32-c6-devkitc-1#47
Conversation
|
Warning Rate limit exceeded
Your organization is not enrolled in usage-based pricing. Contact your admin to enable usage-based pricing to continue reviews beyond the rate limit, or try again in 42 minutes and 48 seconds. ⌛ How to resolve this issue?After the wait time has elapsed, a review can be triggered using the We recommend that you space out your commits to avoid hitting the rate limit. 🚦 How do rate limits work?CodeRabbit enforces hourly rate limits for each developer per organization. Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout. Please see our FAQ for further information. ℹ️ Review info⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (1)
📝 WalkthroughWalkthroughThe changes add a Changes
Estimated code review effort🎯 2 (Simple) | ⏱️ ~8 minutes Poem
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
3bc5303 to
0dadd07
Compare
…it variant When an ESP32 board JSON lacks build.variant, the fallback was the board ID (e.g. "esp32-c6-devkitc-1"), causing fbuild to look for a nonexistent variants/esp32-c6-devkitc-1/ directory instead of variants/esp32c6/. This broke compilation with "pins_arduino.h: No such file or directory". The Arduino ESP32 framework uses the MCU name as the variant directory name, so the fallback now uses MCU for ESP32 boards (core == "esp32"). Non-ESP32 boards retain the existing board_id fallback. Fixes #46 Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
0dadd07 to
8f49b82
Compare
Includes fix for ESP32-C6 variant resolution (#47). Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Summary
esp32-c6-devkitc-1.jsonwas the only ESP32 board (out of 50) missingbuild.variant, causing variant to default to the board ID and look for nonexistentvariants/esp32-c6-devkitc-1/instead ofvariants/esp32c6/"variant": "esp32c6"to the board JSONesp32c6alias pathTest plan
test_esp32c6_devkitc1_has_variant— RED before fix, GREEN aftertest_esp32c6_alias_has_variant— confirms alias path worksfbuild-configsuite (102 tests) passesFixes #46
Cross-ref: FastLED/FastLED#2259
🤖 Generated with Claude Code
Summary by CodeRabbit
Configuration Updates
Tests