Skip to content

fix(esp32c6): add missing build.variant to esp32-c6-devkitc-1#47

Merged
zackees merged 1 commit intomainfrom
fix/esp32c6-missing-variant
Apr 15, 2026
Merged

fix(esp32c6): add missing build.variant to esp32-c6-devkitc-1#47
zackees merged 1 commit intomainfrom
fix/esp32c6-missing-variant

Conversation

@zackees
Copy link
Copy Markdown
Member

@zackees zackees commented Apr 15, 2026

Summary

  • esp32-c6-devkitc-1.json was the only ESP32 board (out of 50) missing build.variant, causing variant to default to the board ID and look for nonexistent variants/esp32-c6-devkitc-1/ instead of variants/esp32c6/
  • Added "variant": "esp32c6" to the board JSON
  • Added regression tests for both the direct board ID and the esp32c6 alias path

Test plan

  • test_esp32c6_devkitc1_has_variant — RED before fix, GREEN after
  • test_esp32c6_alias_has_variant — confirms alias path works
  • Full fbuild-config suite (102 tests) passes
  • CI passes on this PR

Fixes #46
Cross-ref: FastLED/FastLED#2259

🤖 Generated with Claude Code

Summary by CodeRabbit

  • Configuration Updates

    • Enhanced ESP32-C6 DevKit board configuration with improved variant support for accurate build configuration resolution.
  • Tests

    • Added validation tests to ensure ESP32-C6 board configuration properly resolves variant and MCU settings for both full board identifiers and aliases.

@coderabbitai
Copy link
Copy Markdown

coderabbitai Bot commented Apr 15, 2026

Warning

Rate limit exceeded

@zackees has exceeded the limit for the number of commits that can be reviewed per hour. Please wait 42 minutes and 48 seconds before requesting another review.

Your organization is not enrolled in usage-based pricing. Contact your admin to enable usage-based pricing to continue reviews beyond the rate limit, or try again in 42 minutes and 48 seconds.

⌛ How to resolve this issue?

After the wait time has elapsed, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

We recommend that you space out your commits to avoid hitting the rate limit.

🚦 How do rate limits work?

CodeRabbit enforces hourly rate limits for each developer per organization.

Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout.

Please see our FAQ for further information.

ℹ️ Review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: 796e8149-846e-436f-a7ad-865a14de6601

📥 Commits

Reviewing files that changed from the base of the PR and between 3bc5303 and 8f49b82.

📒 Files selected for processing (1)
  • crates/fbuild-config/src/board.rs
📝 Walkthrough

Walkthrough

The changes add a "variant": "esp32c6" configuration field to the ESP32-C6 board JSON and include two new test cases validating that board resolution correctly sets the variant property.

Changes

Cohort / File(s) Summary
Board Configuration
crates/fbuild-config/assets/boards/json/esp32-c6-devkitc-1.json
Added "variant": "esp32c6" field under the "build" object in the board JSON configuration.
Board Tests
crates/fbuild-config/src/board.rs
Added two test cases to validate that BoardConfig::from_board_id() correctly resolves the ESP32-C6 variant property when using both the full board ID and the esp32c6 alias.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~8 minutes

Poem

🐰 A variant field, so crisp and clean,
Makes ESP32-C6 truly seen!
Tests ensure the config's right,
Now pins_arduino.h shines bright! ✨

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title clearly and concisely summarizes the main change: adding the missing build.variant field to the esp32-c6-devkitc-1 board configuration file.
Linked Issues check ✅ Passed The PR adds the missing variant field to the board JSON and includes regression tests validating that the variant is correctly resolved, directly addressing issue #46's core requirement.
Out of Scope Changes check ✅ Passed All changes are directly scoped to fixing issue #46: the board JSON variant addition and corresponding test cases validating the fix.
Docstring Coverage ✅ Passed Docstring coverage is 100.00% which is sufficient. The required threshold is 80.00%.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch fix/esp32c6-missing-variant

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@zackees zackees force-pushed the fix/esp32c6-missing-variant branch from 3bc5303 to 0dadd07 Compare April 15, 2026 20:39
…it variant

When an ESP32 board JSON lacks build.variant, the fallback was the board
ID (e.g. "esp32-c6-devkitc-1"), causing fbuild to look for a nonexistent
variants/esp32-c6-devkitc-1/ directory instead of variants/esp32c6/.
This broke compilation with "pins_arduino.h: No such file or directory".

The Arduino ESP32 framework uses the MCU name as the variant directory
name, so the fallback now uses MCU for ESP32 boards (core == "esp32").
Non-ESP32 boards retain the existing board_id fallback.

Fixes #46

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
@zackees zackees force-pushed the fix/esp32c6-missing-variant branch from 0dadd07 to 8f49b82 Compare April 15, 2026 20:42
@zackees zackees merged commit 5775a04 into main Apr 15, 2026
76 checks passed
@zackees zackees deleted the fix/esp32c6-missing-variant branch April 15, 2026 20:54
zackees added a commit that referenced this pull request Apr 15, 2026
Includes fix for ESP32-C6 variant resolution (#47).

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

ESP32-C6 build fails: missing variant include path for pins_arduino.h

1 participant