Skip to content

Honor forwarded PlatformIO config overrides#56

Merged
zackees merged 1 commit intomainfrom
fix/issue-40-platformio-overrides
Apr 17, 2026
Merged

Honor forwarded PlatformIO config overrides#56
zackees merged 1 commit intomainfrom
fix/issue-40-platformio-overrides

Conversation

@zackees
Copy link
Copy Markdown
Member

@zackees zackees commented Apr 17, 2026

Summary

  • make PlatformIOConfig honor forwarded PLATFORMIO_BUILD_FLAGS and PLATFORMIO_BUILD_SRC_FLAGS
  • prefer forwarded PLATFORMIO_DEFAULT_ENVS and PLATFORMIO_SRC_DIR over INI values
  • add focused parser tests proving forwarded overrides win over platformio.ini

Fixes #40.

Verification

  • cargo test -p fbuild-config
  • cargo fmt --all --check

@coderabbitai
Copy link
Copy Markdown

coderabbitai Bot commented Apr 17, 2026

Warning

Rate limit exceeded

@zackees has exceeded the limit for the number of commits that can be reviewed per hour. Please wait 46 minutes and 59 seconds before requesting another review.

Your organization is not enrolled in usage-based pricing. Contact your admin to enable usage-based pricing to continue reviews beyond the rate limit, or try again in 46 minutes and 59 seconds.

⌛ How to resolve this issue?

After the wait time has elapsed, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

We recommend that you space out your commits to avoid hitting the rate limit.

🚦 How do rate limits work?

CodeRabbit enforces hourly rate limits for each developer per organization.

Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout.

Please see our FAQ for further information.

ℹ️ Review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

Run ID: 7591e992-9f4f-450c-8b66-e87e148a85bf

📥 Commits

Reviewing files that changed from the base of the PR and between e012748 and f4c1ba9.

📒 Files selected for processing (1)
  • crates/fbuild-config/src/ini_parser.rs
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch fix/issue-40-platformio-overrides

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@zackees zackees merged commit c50e56e into main Apr 17, 2026
76 checks passed
@zackees zackees deleted the fix/issue-40-platformio-overrides branch April 17, 2026 06:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Make declared-supported PLATFORMIO_* overrides actually affect native config resolution

1 participant