Skip to content

Write only mismatched ESP32 flash regions#72

Closed
zackees wants to merge 1 commit intomainfrom
codex/issue-67-selective-write-flash
Closed

Write only mismatched ESP32 flash regions#72
zackees wants to merge 1 commit intomainfrom
codex/issue-67-selective-write-flash

Conversation

@zackees
Copy link
Copy Markdown
Member

@zackees zackees commented Apr 17, 2026

Summary

  • parse per-region esptool verify-flash output to identify which ESP32 flash regions actually differ
  • selectively rewrite only the mismatched bootloader/partitions/firmware regions, with a full-flash fallback when the verify transcript is incomplete
  • add deploy-side tests for selective write args and mismatch parsing

Testing

  • cargo fmt --all --check
  • cargo test -p fbuild-deploy esp32 -- --nocapture
  • cargo test -p fbuild-daemon operations -- --nocapture

Closes #67.

@coderabbitai
Copy link
Copy Markdown

coderabbitai Bot commented Apr 17, 2026

Warning

Rate limit exceeded

@zackees has exceeded the limit for the number of commits that can be reviewed per hour. Please wait 42 minutes and 23 seconds before requesting another review.

Your organization is not enrolled in usage-based pricing. Contact your admin to enable usage-based pricing to continue reviews beyond the rate limit, or try again in 42 minutes and 23 seconds.

⌛ How to resolve this issue?

After the wait time has elapsed, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

We recommend that you space out your commits to avoid hitting the rate limit.

🚦 How do rate limits work?

CodeRabbit enforces hourly rate limits for each developer per organization.

Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout.

Please see our FAQ for further information.

ℹ️ Review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

Run ID: 9b5be1f5-7b6b-46b3-a8c7-902ec19121b2

📥 Commits

Reviewing files that changed from the base of the PR and between 1ddef46 and 9d8bb22.

📒 Files selected for processing (2)
  • crates/fbuild-daemon/src/handlers/operations.rs
  • crates/fbuild-deploy/src/esp32.rs
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch codex/issue-67-selective-write-flash

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@zackees
Copy link
Copy Markdown
Member Author

zackees commented Apr 17, 2026

Closing as superseded by #71, which merged the sector-selective ESP32 write-flash change into main while this PR was in flight.

@zackees zackees closed this Apr 17, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

perf(deploy): sector-selective write-flash on verify mismatch

1 participant