fix(deploy): esptool v5 non-deprecated argv spellings#79
Conversation
esptool v5 deprecated the underscored argv tokens `write_flash`, `default_reset`, and `hard_reset`, emitting a warning for each when they are used. Switch the argv we pass to esptool (and the ESP32 MCU JSON configs whose `before_reset`/`after_reset` values flow directly into `--before`/`--after`) to the hyphenated spellings `write-flash`, `default-reset`, `hard-reset` so deploys stay warning-free on v5. Only string values consumed by esptool are changed; Rust field names (`before_reset`, `after_reset`) and function names (`build_write_flash_args`) remain unchanged. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
|
Warning Rate limit exceeded
Your organization is not enrolled in usage-based pricing. Contact your admin to enable usage-based pricing to continue reviews beyond the rate limit, or try again in 1 minutes and 22 seconds. ⌛ How to resolve this issue?After the wait time has elapsed, a review can be triggered using the We recommend that you space out your commits to avoid hitting the rate limit. 🚦 How do rate limits work?CodeRabbit enforces hourly rate limits for each developer per organization. Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout. Please see our FAQ for further information. ℹ️ Review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (11)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
1 participant
Summary
Closes #77.
esptool v5 deprecated the underscored argv tokens used by
fbuild deploy:write_flash->write-flash--before default_reset->--before default-reset--after hard_reset->--after hard-resetRunning a deploy today emits three deprecation warnings before proceeding. This PR updates the exact argv strings passed to esptool so deploys are warning-free on esptool v5.
Scope
crates/fbuild-deploy/src/esp32.rs: change thewrite_flashsubcommand literal, test-fixture defaults (before_reset/after_reset), and the matching assertion. Also updated the/// --after hard_resetdoc-comment literals that describe the effective CLI semantics.crates/fbuild-build/src/esp32/configs/esp32*.json(9 files): updatebefore_reset/after_resetvalues, since they flow directly into the--before/--afterargv passed to esptool.crates/fbuild-build/src/esp32/mcu_config.rs: update the doc-comment examples to match the new values.Rust identifiers (
before_reset,after_resetstruct fields,build_write_flash_argsfunction) are unchanged - this is a pure value/argv rename.Test plan
./_cargo test -p fbuild-deploy- 32 passed, 8 ignored (real-hardware tests)./_cargo clippy --workspace --all-targets -- -D warnings- clean./_cargo fmt --all- no changesCo-Authored-By: Claude Opus 4.7 (1M context) noreply@anthropic.com