fix(python): remove stale _native extension from repo (#75)#83
Merged
Conversation
|
Caution Review failedThe pull request is closed. ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Pro Run ID: ⛔ Files ignored due to path filters (1)
📒 Files selected for processing (4)
📝 WalkthroughWalkthroughThis pull request addresses stale PyO3 native extension binaries by adding Changes
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~3 minutes Possibly related PRs
Poem
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
The compiled PyO3 extension `python/fbuild/_native.pyd` was checked into
the repo and went out of sync with `crates/fbuild-python/src/lib.rs`.
Running tests that import `fbuild._native` (e.g. `test_serial_reset.py`)
failed with AttributeError for symbols like `SerialMonitor.reset_device`
because the committed binary predated the Rust source.
- Remove the stale Windows binary so the working tree never ships a
pre-built extension.
- Gitignore `_native.{pyd,abi3.so,so,dylib}` under `python/fbuild/` so a
freshly-built artifact can never be accidentally committed again.
- Document the local build step in the top-level README and in
`python/README.md` / `python/fbuild/README.md`:
`uv run cargo build --release -p fbuild-python --features extension-module`
followed by copying the artifact into `python/fbuild/`.
Published PyPI wheels are unaffected: `ci/publish.py` already downloads
fresh per-platform extensions from the `build.yml` GitHub Actions run,
so the checked-in binary was only used for local in-tree Python tests.
Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
zackees
force-pushed
the
fix/issue-75-stale-native-pyd
branch
from
1265b7c to
56036ac
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
python/fbuild/_native.pyd, a checked-in PyO3 extension that went stale againstcrates/fbuild-python/src/lib.rsand causedAttributeError: SerialMonitor.reset_devicewhen running Python tests that importfbuild._native.python/fbuild/_native.{pyd,abi3.so,so,dylib}to.gitignoreso a freshly-built artifact cannot be accidentally re-committed.python/README.md/python/fbuild/README.md:uv run cargo build --release -p fbuild-python --features extension-module # then copy target/release/_native.{dll,so,dylib} -> python/fbuild/_native.{pyd,abi3.so}Published PyPI wheels are unaffected —
ci/publish.pyalready pulls fresh per-platform extensions from thebuild.ymlGitHub Actions run. The committed binary was only ever used for local in-tree Python tests.Fixes #75.
Test plan
uv run cargo build --release -p fbuild-python --features extension-modulesucceedspython/fbuild/_native.pyd,from fbuild._native import SerialMonitorexposesreset_device(previously missing on the stale binary)git check-ignore python/fbuild/_native.pydmatches the new.gitignoreentrybuild.ymlstill produces_native.pyd/_native.abi3.soartifacts (workflow unchanged)./publishwheel assembly still finds the extensions (publish.py unchanged)Summary by CodeRabbit
Documentation
Chores