Merged
Conversation
…ethod and Richardson extrapolation. Added test cases for resampling and the 4th order method. All old tests should pass. Newton refinement and computation of residues/norming constants yet to be fixed for 4th order method.
…attering method. Adapted Newton refinement and computation of norming_constants/residues to higher-order method. All tests pass.
…polation for CS and DS. Extrapolation works as expected for CS and bound-states but not for normconst_or_residues. All current tests pass.
…or Richardson extrapolation to some tests. In test sech_focusing_4split4A, the overall order with Richardson step is less than expected. Reason for the same not known.
…th-order method. Added fourth-order method CF4_2 to akns_scatter_matrix. Corrected typo in mex_fnft_nsev_inverse. Removed a TODO related to CDT in fnft_nsev_invserse. Fixed error in example fnft_nsev_inverse_test_addsoliton_cdt which was requiring the TODO.
…thod. Accuray isn't higher of higher-order method. TODO: Check is changes are needed before call to poly_roots_fftgridsearch. Removed constraint on D to be power of two.
…:The locations of samples that need to be supplied is different. Updated all test cases of nsep and fnft_nsep_example. Updated mex_fnft_nsep files and MATLAB example. Some issue with poly_roots_fftgridsearch when D is not a power of 2 which causes some test to fail.
… to be associated with 'p'polynomial. Small correction in misc_resample. Updated mex_fnft_nsev to support higher-order methods. Added MATLAB example to recreate a plot from the paper.
…er of coefficients. misc_resample changed to use FFT of same length as number of given samples.
…ile nft_nsev was created for slow NFT methods (contspec only). Some test files for it were also added. Intgeration into fnft_nsev instead is not straightforward.
…ev. Added tests for nft_nsev focusing case. Implemented new method based on Peter's paper for computing norming constants in nse_scatter_bound_states. Updated related codes.
…ded forgotten files.
…er-order methods.
…rguments. If skip_b_flag == 1, the computation of b is skipped which halves the computation time of the function.
…tainability. However new code requires more memory and is slightly slower.
…bility. Added higher-order CF methods to nse_scatter_bound_states.
Merge the final changes from release 0.3 back into development
…es for building transfer matrix should be even. Changed Dsub calculation to find even number instead of power of 2.
…O: Tests with quasiperiodic signal.
…ng and one defocusing test for quasi-periodic signals. Updated nsep related documentation. Updated mex_fnft_nsep file and its documentation. Updated nsep example.
…r bug fixes to nsev_slow. Created mex file for nsev_slow and added two MATLAB examples.
…r computation of only the scattering coefficients without their derivatives. This leads to potential speed-up of factor 4 in computing continuous spectrum using nsev_slow.
…r them. Yet to implement code for derivatives of scattering coeffs. Created method_order functions which returns order of method. It is required for Richardson extrapolation.
…es_newton. Created prototype function for misc_square_matrix_mult named misc_mat_mult_NxN. Created two specific functions misc_mat_mult_2x2 and misc_mat_mult_4x4. Changed creterion for warning in misc_resample to l2norm based on 90percent bandwidth. Updated all related routines and documentation. Some other small fixes.
…cumentation update to fnft_nsev_slow.
…nft_nsev_slow. For example, Boffetta-Osborne method is now called with discr_BO instead of just BO. This is so that it is inline with the input strings in mex_fnft_nsev.
…tion for the same. Updated related example.
…ates unknown discretization.
…es as sech_focusing2. Renamed nsev_slow_testcases_test_fnft from nsev_slow_testcases to nsev_testcases_test_fnft_slow and moved to nsev_testcases. Deleted nsev_slow_testcases .c and .h. Updated all fnft_nsev_slow tests accordingly.
…ompute_boundstates for fnft_nsev_base and fnft_nsev_base_slow.
… function nsev_compute_normconsts_or_residues for fnft_nsev_base and fnft_nsev_base_slow.
… nsev_compute_contspec for fnft_nsev_base and fnft_nsev_base_slow. Added calculation of phase factors for slow methods in fnft__nse_discretization.
…re now handled by the same main and base functions.
…igher-order root is hit exactly
…h. Updated nsev_refine_bound_states_newton to have bounding_box as input.
…rce file name was violated for some discretization-related functions
…ize core features first
Higher order
|
From the documentation of |
Contributor
Author
Yes, please. I also noted that in the README
should be
Could you please change that as well, in one go? |
|
On it. |
|
Complies correctly and all tests pass with gcc 7.5.0 with and without FFTW. |
ShrinivasJC
approved these changes
Jul 8, 2020
Contributor
Author
|
Thank you! I will release and also update the online documentation. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.