Correct the executable path for osx#170
Merged
TrentHouliston merged 1 commit intomainfrom Jan 25, 2025
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
on osx, the executable path was using the size variable, however this wasn't holding the number of bytes put in the buffer, it instead just is used to output the required size if there was not enough. As a result, the string had nulls in it. Later when it was concatenated with an extension for traces, the nulls meant that the final path was just the binary name which was overwritten.
since PATH_MAX is used as the buffer size, we don't need to look at the space required as it should be PATH_MAX or less by definition.