Merged
Conversation
JosephusPaye
requested changes
Mar 6, 2023
Collaborator
JosephusPaye
left a comment
JosephusPaye
left a comment
There was a problem hiding this comment.
A quick review of mostly the JS changes
Collaborator
|
Also, we'll need to add documentation/usage info in the README. |
awann-4ai
requested review from
JosephusPaye and
TrentHouliston
and removed request for
JosephusPaye and
TrentHouliston
JosephusPaye
requested changes
Mar 30, 2023
JosephusPaye
requested changes
Apr 3, 2023
Collaborator
JosephusPaye
left a comment
JosephusPaye
left a comment
There was a problem hiding this comment.
One main request, the rest are minor comment adjustments for consistency
Co-authored-by: Josephus Paye II <j.paye96@gmail.com>
JosephusPaye
requested changes
Apr 3, 2023
JosephusPaye
approved these changes
Apr 3, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds an encoder allowing NBS files to be written.