Skip to content

Conversation

@patrickhyw
Copy link
Contributor

@patrickhyw patrickhyw commented Apr 1, 2024

Summary: Some changes as I tried to get the code running.

Details:

  • Fixed some versions in requirements.txt to avoid errors.
  • Updated .gitignore to ignore .idx files.
  • Fixed typo in README.
  • Updated error message to print the error.
  • Added some comments to the search() function of lib.rs.

@zhenyuhe00
Copy link
Collaborator

Hi, thanks for your help in making the code clearer. I wonder if datastore/get_datastore_chat.py could remain unchanged since a small datastore is important for situations with limited resources.

@patrickhyw patrickhyw closed this Apr 2, 2024
@patrickhyw patrickhyw deleted the datastore-testing branch April 2, 2024 14:04
@patrickhyw patrickhyw restored the datastore-testing branch April 2, 2024 15:05
@patrickhyw patrickhyw reopened this Apr 2, 2024
@patrickhyw patrickhyw changed the title Datastore testing Small QOL changes Apr 2, 2024
@patrickhyw
Copy link
Contributor Author

patrickhyw commented Apr 2, 2024

Fixed! Let me know if you want to change anything else.

@zhenyuhe00 zhenyuhe00 merged commit a5b8fed into FasterDecoding:main Apr 3, 2024
@patrickhyw patrickhyw deleted the datastore-testing branch April 6, 2024 19:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants