uptake scala 2.13.0-M5 #392
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| type ChampHashMap[A, B] = immutable.ChampHashMap[A, B] | ||
| type ChampHashSet[A] = immutable.ChampHashSet[A] | ||
| type ChampHashMap[A, B] = immutable.HashMap[A, B] | ||
| type ChampHashSet[A] = immutable.HashSet[A] |
Member
There was a problem hiding this comment.
Since these were "added" only because of the scala 2.13 branch, let's remove them from all package.scala (including 2.12, etc) files and drop any tests that reference them. You can probably do a find-all of Champ and drop all blocks/tests with lines referencing it. Thanks!
Member
Author
|
@nbauernfeind removed all references to the Champ classes |
Member
|
Thanks! I will set aside some time in my early tomorrow to release this. |
Contributor
|
@nbauernfeind Thank you for working on this! Are you going to release jars very soon? |
seratch
added a commit
to seratch/skinny-micro
that referenced
this pull request
Oct 14, 2018
still waiting for jackson-scala-module release FasterXML/jackson-module-scala#392
seratch
added a commit
to seratch/skinny-micro
that referenced
this pull request
Oct 14, 2018
still waiting for jackson-scala-module release FasterXML/jackson-module-scala#392
seratch
added a commit
to seratch/skinny-micro
that referenced
this pull request
Oct 14, 2018
still waiting for jackson-scala-module release FasterXML/jackson-module-scala#392
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ChampHashMap and ChampHashSet are not renamed HashMap and HashSet
https://contributors.scala-lang.org/t/champhashmap-champhashset-changes-in-2-13-0-m5/2445
#391