scala 2.13.0-RC3 build #413
Conversation
|
@pjfanning if they are reflection based failures then the following W/A should help: json4s/json4s@e3a6ba0#diff-203589bc2eb21dd281784b3a86f4d806R319 |
|
Thanks @plokhotnyuk - I'll comment on scala/bug#11542 to see if the scala team can check the jackson-module-scala issue too |
|
The issue fixed by this PR is that Option now extends IterableOnce, so some type tests had to be done in a different order to avoid Option being treated like a collection. Note that we're about to release RC3 soon. While I suggest this PR is ready to merge (it wouldn't impact older Scala version support), it would be great if you could release for both RC2 and RC3. |
| } | ||
| getTypeFactory.constructMapLikeType(clazz, typeArguments(0), typeArguments(1)) | ||
| } else if (isCollectionLike(clazz)) { | ||
| } else if (isReference(clazz)) { // Option is a subclss of IterableOnce, so check it first |
There was a problem hiding this comment.
Here's the core of the fix: Option needs to be checked before IterableOnce, since Option does extend IterableOnce now, but it needs its own mapper.
|
switch to RC3 scala version |
|
@nbauernfeind @mbknor would it be possible to merge this and do a publish for scala 2.13.0-RC3? |
|
I'll have a look at it |
|
tx. merged. I'll try to make a 2.9.9 for scala 2.13.0-RC3 asap |
|
Release should be on its way to maven central |
5 participants
scala 2.13.0-RC2 tests initially failed but I was directed to some fixes created by @adriaanm in the scalacommunity build