Skip to content

Conversation

@pjfanning
Copy link
Member

Copy code from 2.12 branch

@pjfanning pjfanning self-assigned this Aug 28, 2020
@pjfanning pjfanning marked this pull request as draft August 28, 2020 07:52
@cowtowncoder
Copy link
Member

cowtowncoder commented Aug 28, 2020

I can't give much feedback but I do like avoiding having to wrap Scala types in JDK equivalents, and that little bit of insulation is probably a good idea for stability -- even if adding little bit of duplication.
So +1 for changes.

Mostly we need to figure out what would be a good way to get changes in jackson-databind "default" handling propagated to other modules, Scala module as well as various data type modules.

@pjfanning
Copy link
Member Author

@cowtowncoder just as an example, as well as avoiding the conversion from Scala to Java collections (which can be cheap enough because in most case wrappers are used, instead of creating brand new collections), I've tried to avoid calls to get the collection size as that can be expensive in some scala collections (eg singly linked lists).

@pjfanning pjfanning marked this pull request as ready for review September 4, 2020 18:03
@pjfanning pjfanning merged commit b06a576 into FasterXML:master Sep 4, 2020
@pjfanning pjfanning deleted the master-iterable-serializer branch September 4, 2020 18:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants