Module builder

[pjfanning]

#525

[cowtowncoder]

Nothing much to comment since I am not familiar enough to offer much useful feedback.
Just one question: from the way it is passed, the "builder" sounds more like it might be a Configuration/settings object?
If so, maybe it'd be make sense to name it as such? (if I am mistaken about intent, apologies).

[pjfanning]

@cowtowncoder this 'Builder' class follows the Builder pattern and is used to build a ScalaModule (which extends the JacksonModule/Module)

[cowtowncoder]

@pjfanning Ok then I am confused. From changes it seemed odd that it would be passed to (de)serializers and value instantiators and so on. I'll see if I can grok the flow with more context.

[pjfanning]

I can rename the ReadOnlyBuilder trait as Config - would make that part of the code more readable

[cowtowncoder]

@pjfanning on builder arg passed, yes, I can see now how it adds things to be added via SetupContext.

[cowtowncoder]

@pjfanning Ah. On ReadOnlyBuilder as base -- not sure what makes most sense. Given that it really is an internal base type I don't have a strong opinion here.