Skip to content

fix issue with JsonProperty name override for constructor vars #782

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Nov 11, 2025
Merged

fix issue with JsonProperty name override for constructor vars #782

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
07d9832
Update CaseClassDeserializerTest.scala
pjfanning Nov 10, 2025
9ac67b5
Update CaseClassDeserializerTest.scala
pjfanning Nov 11, 2025
debe2f6
Update CaseClassDeserializerTest.scala
pjfanning Nov 11, 2025
7496d9a
Update ScalaAnnotationIntrospectorModule.scala
pjfanning Nov 11, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/main/scala/tools/jackson/module/scala/introspect/ScalaAnnotationIntrospectorModule.scala
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -68,7 +68,7 @@ class ScalaAnnotationIntrospectorInstance(scalaAnnotationIntrospectorModule: Sca
case _ => {
val modifiedName = ann match {
case af: AnnotatedField if af.getName.contains("$") => fieldName(af)
case am: AnnotatedMethod if am.getName.contains("$") => methodName(am)
//case am: AnnotatedMethod if am.getName.contains("$") => methodName(am)
case ap: AnnotatedParameter if ap.getName.contains("$") => paramName(ap)
case _ => None
}
Expand Down
4 changes: 2 additions & 2 deletions src/test/scala/tools/jackson/module/scala/deser/CaseClassDeserializerTest.scala
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,7 @@ object CaseClassDeserializerTest {
var stringProperty: String = _
}

case class JacksonAnnotationTestCaseClass(@JsonProperty("foo") oof:String, bar: String)
case class JacksonAnnotationTestCaseClass(@JsonProperty("foo") oof: String, bar: String)

case class GenericTestCaseClass[T](data: T)

Expand Down Expand Up @@ -290,7 +290,7 @@ class CaseClassDeserializerTest extends DeserializerTest {

it should "deserialize AnnotatedVarTestConstructor" in {
val input = """{"t":123}"""
val res = JsonMapper.builderWithJackson2Defaults().build().readValue(input, classOf[AnnotatedVarTestConstructor])
val res = newMapper.readValue(input, classOf[AnnotatedVarTestConstructor])
res.test shouldEqual 123
}
}