Fix #22: add static fields to ResolvedTypeWithMembers#23
Closed
arikkfir wants to merge 12 commits intoFasterXML:masterfrom
arikkfir:master
Closed
Fix #22: add static fields to ResolvedTypeWithMembers#23arikkfir wants to merge 12 commits intoFasterXML:masterfrom arikkfir:master
arikkfir wants to merge 12 commits intoFasterXML:masterfrom
arikkfir:master
Conversation
…" (added a test)
… original formatting)
Member
|
Ok sounds good; I will probably have to manually integrate changes, which is ok. I can also add some basic tests. Thank you very much for suggestion & showing needed changes. I can take it from here. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request adds static fields support to ResolvedTypeWithMembers. I'm sorry it doesn't include a test for that, as I haven't had time to look at the existing tests already existing and creating the appropriate additions :(
Also in order to adapt the project to work in my environment I changed the pom.xml file - and I'm not sure how to create a pull request that only contains "ResolvedTypeWithMembers.java" and not the pom.xml - so obviously you don't need to merge the pom.xml changes, only the "ResolvedTypeWithMembers.java" file.