Conversation
…ove performance This commit streamlines the iframe selection script by removing unnecessary console logging statements across various modules. The changes enhance performance and reduce clutter in the console output, while maintaining essential functionality. Additionally, a check is added to prevent multiple executions of the script, ensuring efficient operation within iframes.
…r ThemeStudio script injection This commit updates the injectAssets function to accept an optional domain parameter, allowing for the injection of the ThemeStudio script based on the store's domain. Additionally, the dynamic-page-renderer is modified to pass the domain when calling injectAssets, ensuring that the script is correctly injected for each store. This change improves the flexibility and functionality of asset injection in rendered HTML.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.