Conversation
…overriding c.currentSpec with the declared spec name (simpleA) instead of the import alias (simple), so c.specs[simple] was never created. Fixed by pre-setting the alias before calling processSpec and skipping the override when isImport = true. 2. compileIdent missing alias resolution (compiler.go): compileIdent didn't call AliasToBaseRaw, unlike compileParameterCall and compileInfixNode. This mattered because const references from imports compile as *ast.Identifier. Fixed by adding the alias resolution. 3. Wrap.WriteRule bounds check (rules.go): Only checked if the OnEntry map was empty, not whether the specific variable had a valid entry. Global constants never get phi entries, so the access panicked. Fixed by also checking len(OnEntry[w.Value]) <= w.PhiLevel. 4. Bool constants emit 1/0 instead of true/false (unroll.go): *constant.Int with i1 type was emitting the integer string 1 in SMT, which is incompatible with Bool sort. Fixed to emit true/false.
…er than an instance. This is only allowed in assumptions/assertions
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.