fix: mark Logger in Parser GC to prevent use-after-free#100
Merged
stackmystack merged 1 commit intoFaveod:masterfrom Feb 19, 2026
Merged
fix: mark Logger in Parser GC to prevent use-after-free#100stackmystack merged 1 commit intoFaveod:masterfrom
stackmystack merged 1 commit intoFaveod:masterfrom
Conversation
Parser was not marking the Logger Ruby object during GC, causing the Logger to be collected while still referenced by tree-sitter's C callback. This adds mark/compact functions to parser_t and stores the Logger VALUE so GC keeps it alive. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
3 tasks
Collaborator
|
Thanks again! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Noticed in #99 CI that
Parserdoes not mark theLoggerRuby object during GC, causing use-after-free when GC collects the Logger while tree-sitter still holds a callback pointer to it.Adds
dmark/dcompacttoparser_data_typeand storesVALUE loggerinparser_t.