Skip to content
This repository was archived by the owner on Feb 21, 2024. It is now read-only.

Import roaring endpoint accepts a list of views#1738

Merged
yuce merged 7 commits intoFeatureBaseDB:masterfrom
yuce:1716-roaring-import-for-time-fields
Nov 21, 2018
Merged

Import roaring endpoint accepts a list of views#1738
yuce merged 7 commits intoFeatureBaseDB:masterfrom
yuce:1716-roaring-import-for-time-fields

Conversation

@yuce
Copy link
Contributor

@yuce yuce commented Nov 12, 2018

Overview

  • Adds a protobuf message for passing an ImportRoaringRequest which sends view data together with import options.
  • Moved Clear import option from the query arg to the protobuf message

TODO: Need to update an handler test so it posts encoded ImportRoaringRequest data. Fixed handlers tests.

Fixes #1716

Pull request checklist

Code review checklist

This is the checklist that the reviewer will follow while reviewing your pull request. You do not need to do anything with this checklist, but be aware of what the reviewer will be looking for.

  • Ensure that any changes to external docs have been included in this pull request.
  • If the changes require that minor/major versions need to be updated, tag the PR appropriately.
  • Ensure the new code is properly commented and follows Idiomatic Go.
  • Check that tests have been written and that they cover the new functionality.
  • Run tests and ensure they pass.
  • Build and run the code, performing any applicable integration testing.

@yuce yuce changed the title Import roaring enpoint accepts a list of views [WIP] Import roaring enpoint accepts a list of views Nov 12, 2018
@yuce yuce changed the title [WIP] Import roaring enpoint accepts a list of views Import roaring enpoint accepts a list of views Nov 14, 2018
@travisturner travisturner changed the title Import roaring enpoint accepts a list of views Import roaring endpoint accepts a list of views Nov 20, 2018
travisturner
travisturner previously approved these changes Nov 21, 2018
@yuce
Copy link
Contributor Author

yuce commented Nov 21, 2018

@travisturner Can you approve this again? I've added a check for empty data and merged with master which removed your approval review.

@yuce yuce merged commit 2447b5d into FeatureBaseDB:master Nov 21, 2018
@yuce yuce deleted the 1716-roaring-import-for-time-fields branch November 21, 2018 15:54
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Enable /import-roaring endpoint for time fields

3 participants