This repository was archived by the owner on Feb 21, 2024. It is now read-only.
Import roaring endpoint accepts a list of views#1738
Merged
yuce merged 7 commits intoFeatureBaseDB:masterfrom Nov 21, 2018
Merged
Import roaring endpoint accepts a list of views#1738yuce merged 7 commits intoFeatureBaseDB:masterfrom
yuce merged 7 commits intoFeatureBaseDB:masterfrom
Conversation
travisturner
suggested changes
Nov 20, 2018
travisturner
previously approved these changes
Nov 21, 2018
Contributor
Author
|
@travisturner Can you approve this again? I've added a check for empty data and merged with master which removed your approval review. |
travisturner
approved these changes
Nov 21, 2018
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Overview
ImportRoaringRequestwhich sends view data together with import options.Clearimport option from the query arg to the protobuf messageTODO: Need to update an handler test so it posts encodedFixed handlers tests.ImportRoaringRequestdata.Fixes #1716
Pull request checklist
Code review checklist
This is the checklist that the reviewer will follow while reviewing your pull request. You do not need to do anything with this checklist, but be aware of what the reviewer will be looking for.