Skip to content
This repository was archived by the owner on Sep 28, 2022. It is now read-only.

Fix Column create for Key Column Values#127

Merged
yuce merged 1 commit intoFeatureBaseDB:masterfrom
mikejdorm:column-create-fix
Oct 11, 2018
Merged

Fix Column create for Key Column Values#127
yuce merged 1 commit intoFeatureBaseDB:masterfrom
mikejdorm:column-create-fix

Conversation

@mikejdorm
Copy link
Copy Markdown

The column key values passed to the following create methods are incorrectly getting set to the rowKey variable.

    public static Column create(long rowID, String columnKey) {
        return create(rowID, 0, columnKey, "", 0);
    }

    public static Column create(long rowID, String columnKey, long timestamp) {
        return create(rowID, 0, columnKey, "", timestamp);
    }

For comparison, method signature for the create method is the following.

    private static Column create(long rowID, long columnID, String rowKey, String columnKey, long timestamp)

This pull request switches the order of the arguments so the column key gets set properly.

@coveralls
Copy link
Copy Markdown

Coverage Status

Coverage remained the same at 100.0% when pulling d5d1611 on mikejdorm:column-create-fix into 734a8e1 on pilosa:master.

@yuce
Copy link
Copy Markdown
Contributor

yuce commented Oct 11, 2018

Thanks, will push a new version of the client shortly.

@yuce yuce merged commit 24f9d96 into FeatureBaseDB:master Oct 11, 2018
@mikejdorm
Copy link
Copy Markdown
Author

Thanks @yuce. Appreciate it!

@yuce
Copy link
Copy Markdown
Contributor

yuce commented Oct 11, 2018

@mikejdorm I've just published version 1.0.2. It seems to be live.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants