Skip to content
This repository was archived by the owner on Sep 28, 2022. It is now read-only.

[TRIVIAL] Add keys field option#111

Merged
yuce merged 6 commits intoFeatureBaseDB:masterfrom
yuce:add-keys-field-option
Jul 20, 2018
Merged

[TRIVIAL] Add keys field option#111
yuce merged 6 commits intoFeatureBaseDB:masterfrom
yuce:add-keys-field-option

Conversation

@yuce
Copy link
Contributor

@yuce yuce commented Jul 19, 2018

This PR contains docs updates which were accidentally pushed to develop last time. The not-yet-reviewed changes are in this commit: 5253097

@coveralls
Copy link

coveralls commented Jul 19, 2018

Coverage Status

Coverage remained the same at 100.0% when pulling 01c7cf9 on yuce:add-keys-field-option into 1e2f73a on pilosa:master.

Copy link
Member

@travisturner travisturner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

just the one change

pilosa/orm.py Outdated
:param int cache_size: Values greater than 0 sets the cache size. Otherwise uses the default cache size
:param int int_min: Minimum for the integer field
:param int int_max: Maximum for the integer field
:param bool keys: Sets whether field uses string keys
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For consistency, let's change this to Whether the field uses string keys

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Updated

@yuce yuce merged commit 83cde56 into FeatureBaseDB:master Jul 20, 2018
@yuce yuce deleted the add-keys-field-option branch July 20, 2018 19:41
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants