Skip to content
This repository was archived by the owner on Sep 28, 2022. It is now read-only.

Updated keys support#112

Merged
yuce merged 3 commits intoFeatureBaseDB:masterfrom
yuce:updated-keys-support
Jul 25, 2018
Merged

Updated keys support#112
yuce merged 3 commits intoFeatureBaseDB:masterfrom
yuce:updated-keys-support

Conversation

@yuce
Copy link
Contributor

@yuce yuce commented Jul 23, 2018

No description provided.

@coveralls
Copy link

coveralls commented Jul 23, 2018

Coverage Status

Coverage remained the same at 100.0% when pulling 829b14c on yuce:updated-keys-support into 83cde56 on pilosa:master.

pilosa/client.py Outdated
:param bool exclude_columns: Disables returning columns from row queries
:param bool exclude_attrs: Disables returning attributes from row queries
:param list(int) slices: Returns data from a subset of slices
:param list(int) shards: Returns data from a subset of slices
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

slices > shards

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Updated

@yuce
Copy link
Contributor Author

yuce commented Jul 25, 2018

@travisturner Is it OK to merge this one?

Copy link
Member

@travisturner travisturner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

a couple more comments

pilosa/orm.py Outdated

:param str name: index name
:param str name: Index name
:param bool keys: Whether the field uses string keys
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I believe this should be "index" instead of "field"

pilosa/orm.py Outdated

:param str name: index name
:param str name: Index name
:param bool keys: Whether the field uses string keys
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

same here, field > index

@yuce
Copy link
Contributor Author

yuce commented Jul 25, 2018

@travisturner fixed the doc strings.

@yuce yuce merged commit 9ae6414 into FeatureBaseDB:master Jul 25, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants