Skip to content
This repository was archived by the owner on Sep 28, 2022. It is now read-only.

Implements the Store call#125

Merged
yuce merged 2 commits intoFeatureBaseDB:masterfrom
yuce:store-call
Oct 11, 2018
Merged

Implements the Store call#125
yuce merged 2 commits intoFeatureBaseDB:masterfrom
yuce:store-call

Conversation

@yuce
Copy link
Contributor

@yuce yuce commented Oct 4, 2018

Fixes #126
Requires Pilosa built from FeatureBaseDB/featurebase#1666

@yuce yuce requested a review from codysoyland October 4, 2018 14:56
@yuce yuce changed the title Implements the Store call [DONT MERGE] Implements the Store call Oct 4, 2018
@yuce
Copy link
Contributor Author

yuce commented Oct 5, 2018

Since Store PR was merged to Pilosa master, this PR can be merged.

@yuce yuce changed the title [DONT MERGE] Implements the Store call Implements the Store call Oct 5, 2018
@yuce
Copy link
Contributor Author

yuce commented Oct 9, 2018

ping!

@alanbernstein
Copy link
Contributor

alanbernstein commented Oct 11, 2018

This looks good, but I'm having trouble passing tests.

Pilosa v1.1.0-176-gf62dbc00, build time 2018-10-11T15:07:15+0000, starting with an empty data directory

make test-all -> 3 failed, 137 passed in 5.55 seconds

The following three all fail in similar ways:
ClientIT.test_csv_import_time_field
ClientIT.test_not_
ClientIT.test_store

trimmed output from test_store:

self = <pilosa.client.Client object at 0x10543ecd0>, method = 'POST', path = '/index/testidx-30/field/exists'
data = '{"options": {"timeQuantum": "", "type": "time"}}', headers = None, use_coordinator = False
...
E       PilosaServerError: Server error (500): {"success":false,"error":{"message":"reserved index or field name"}}

pilosa/client.py:367: PilosaServerError

Am I doing something wrong here?

I got tests to pass by continueing if field_name == 'exists' in the first field loop of sync_schema, but it's not clear why I'm seeing errors here if you're not.

@yuce
Copy link
Contributor Author

yuce commented Oct 11, 2018

Found the issue, pushing a fix in a few.

@yuce
Copy link
Contributor Author

yuce commented Oct 11, 2018

Thanks for noticing that problem, I've pushed a fix.

@coveralls
Copy link

Coverage Status

Coverage remained the same at 100.0% when pulling 68d3046 on yuce:store-call into c460cdc on pilosa:master.

Copy link
Contributor

@alanbernstein alanbernstein left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@yuce yuce merged commit a2a9a6f into FeatureBaseDB:master Oct 11, 2018
@yuce yuce deleted the store-call branch October 11, 2018 21:00
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants