Skip to content
This repository was archived by the owner on Sep 28, 2022. It is now read-only.

Added initial tracing support.#140

Merged
yuce merged 2 commits intoFeatureBaseDB:masterfrom
yuce:tracing-support
Apr 18, 2019
Merged

Added initial tracing support.#140
yuce merged 2 commits intoFeatureBaseDB:masterfrom
yuce:tracing-support

Conversation

@yuce
Copy link
Contributor

@yuce yuce commented Apr 17, 2019

Fixes #141

@coveralls
Copy link

Coverage Status

Coverage increased (+0.03%) to 98.513% when pulling 51017cb on yuce:tracing-support into 5ec3152 on pilosa:master.

@coveralls
Copy link

coveralls commented Apr 17, 2019

Coverage Status

Coverage increased (+0.02%) to 98.502% when pulling fd15a49 on yuce:tracing-support into 5ec3152 on pilosa:master.

@alanbernstein
Copy link
Contributor

I'm trying to run the example script, but I'm getting an odd error:

$ python tracing-test.py
Traceback (most recent call last):
  File "tracing-test.py", line 42, in <module>
    main()
  File "tracing-test.py", line 29, in main
    schema = client.schema()
  File "/Users/abernstein/src/pilosa/python-pilosa/pilosa/client.py", line 280, in schema
    with self.tracer.scope_manager.activate(span, True) as scope:
AttributeError: 'Tracer' object has no attribute 'scope_manager'

Some version info:

$ pip install jaeger-client
Requirement already satisfied: jaeger-client in /usr/local/lib/python3.7/site-packages (3.13.0)
Requirement already satisfied: thrift in /usr/local/lib/python3.7/site-packages (from jaeger-client) (0.11.0)
Requirement already satisfied: tornado<5,>=4.3 in /usr/local/lib/python3.7/site-packages (from jaeger-client) (4.5.3)
Requirement already satisfied: opentracing<2,>=1.2.2 in /usr/local/lib/python3.7/site-packages (from jaeger-client) (1.3.0)
Requirement already satisfied: threadloop<2,>=1 in /usr/local/lib/python3.7/site-packages (from jaeger-client) (1.0.2)
Requirement already satisfied: six>=1.7.2 in /usr/local/lib/python3.7/site-packages (from thrift->jaeger-client) (1.11.0)

I wonder if there is a better way for me to use this branch of the pilosa client while using the test script?

@yuce
Copy link
Contributor Author

yuce commented Apr 18, 2019

It seems jaeger client is not compatible with OpenTracing 2, I've downgraded it to 1.3.0

@alanbernstein
Copy link
Contributor

With this change, the script finishes, but in the Jaeger UI, I only see jaeger-query in the service dropdown

Copy link
Contributor

@alanbernstein alanbernstein left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The updated docker command fixed my problem

@yuce
Copy link
Contributor Author

yuce commented Apr 18, 2019

Great!

@yuce yuce merged commit 82a5ed8 into FeatureBaseDB:master Apr 18, 2019
@yuce yuce deleted the tracing-support branch April 18, 2019 18:10
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add tracing support

3 participants