feat: add stable rollout function for FPUser #20
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #20 +/- ##
============================================
- Coverage 78.30% 77.47% -0.84%
Complexity 266 266
============================================
Files 32 32
Lines 931 941 +10
Branches 62 62
============================================
Hits 729 729
- Misses 166 175 +9
- Partials 36 37 +1
|
dengfeige
approved these changes
Aug 25, 2022
FengShang
reviewed
Aug 25, 2022
|
|
||
| public HitResult findIndex(FPUser user, String toggleKey) { | ||
| String hashKey = user.getKey(); | ||
| String hashKey = user.getKey() != null ? user.getKey() : String.valueOf(System.nanoTime()); |
Member
There was a problem hiding this comment.
Should set this value back to user.key. This user may be used many times.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.