Should these five rules carry timeframe_type/timeframe_num? #164
ktalons
started this conversation in
20x Discussion
Replies: 1 comment
|
Catching up - I did the timeframes mostly by hand and probably missed these. I will add it to my list for an update to fix! |
0 replies
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Uh oh!
There was an error while loading. Please reload this page.
Sharing a consistency check I ran in a personal capacity while building against the consolidated rules dataset.
I'm planning to maintain an open-source tool that computes VDR and VER response deadlines by reading
fedramp-consolidated-rules.jsonrather than embedding the numbers, so that a change to a cadence upstream reaches the tool without a code change. That means every timeframe has to be derivable from the data. I walked all 246 FRR rules atv2026.07.14.01to find the ones where it is not.What holds, and it holds cleanly. The dataset encodes timeframes in two shapes and is consistent about both, and
AGENTS.mddocuments both placements: it lists simple timeframes among the fields a class-specific variant may carry, and again among the "other useful top-level fields" a requirement may carry. Rules that vary by class puttimeframe_typeandtimeframe_numinside eachvaries_by_classentry. Flat rules carry the same pair at the top level, and 17 of them do:AFC-FRP-PNT(bizdays 10),CDS-CSO-FRC(weeks 2),CDS-UTC-AAD(bizdays 5), sixREC-IAS-*rules, fiveSCN-*rules, andVER-TFR-MHR(months 1) andVER-TFR-MAV(days 192). No rule mixes the two shapes. As a consumer that is genuinely nice to work against.The exceptions. Five flat rules state a numeric timeframe in the statement and encode nothing:
VDR-TFR-NMVCCM-OCR-AVLIVV-CSF-MCAMKT-IIP-DLAMKT-CAS-RFRA sixth,
CCM-QTR-SAR, states a two-sided window ("at least 3 business days after ... AND within 10 business days of such release") that a singletimeframe_type/timeframe_numpair cannot express, so I have left it out rather than counting it as a gap.To be clear about what this is not: nothing here is a schema violation.
dependentRequiredinfrr_requirementandfrr_requirement_levelonly pairs the two fields when one is present, so the file validates today either way. This is about what a consumer can derive.Consumer consequence. Any tool that builds a compliance calendar from
timeframe_type/timeframe_numsilently drops these five cadences, and all five are MUST rules.VDR-TFR-NMVis the one that bites me directly: every other timeframe in my VDR and VER calculations comes out of the data, and this one has to be hardcoded, which is exactly the failure the structured fields prevent.VDR-TFR-PDDsits one rule below it and its Class A value ismonths/3, the same cadence NMV states in prose.The question. Is the omission deliberate on some or all of these? I can see an argument that a verification cadence is a different kind of thing from a response clock and was left unencoded on purpose. If so, I would rather record that as a documented decision than carry a hardcoded exception. If it is simply a gap, each is a two-line addition, and I am happy to open a PR if that is useful.
Also worth linking: @badgerinspace raised
VDR-TFR-NMVfrom the interpretation side in this comment on #146 on 2026-08-05, still unanswered. Different question, same rule.Kyle Versluis (personal capacity)
All reactions