Merged
Conversation
veasion
approved these changes
Mar 4, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
这个 PR 尝试修复在执行
getTabId函数时出现的 "Could not find a valid tab" 报错。这个 PR 做了以下修改:getTabId函数中获取windowId的方式从let windowId = context.variables.get('windowId') as any;修改为let windowId = await getWindowId(context);;getCurrentTabId的实现,现在它不再返回不期望的undefined了;这个 PR 的验证需要很多“在当前标签页操作”的用例(例如“点开这个页面的第一个链接”)。
This PR attempts to fix the "Could not find a valid tab" error that occurs when executing the
getTabIdfunction. The following changes have been made in this PR:windowIdin thegetTabIdfunction has been changed fromlet windowId = context.variables.get('windowId') as any;tolet windowId = await getWindowId(context);.getCurrentTabIdhas been modified so that it no longer returns the undesiredundefined.The verification of this PR requires numerous use cases involving "operating within the current tab" (e.g., "click on the first link on this page").