Conversation
mdiluz
commented
May 25, 2019
mdiluz
commented
- README restructure and cleanup
- Source file rename and restructure
- Wine code full separation into wine file
- Include cleanup
- Comment cleanup
mdiluz
force-pushed
the
the-big-cleanup
branch
2 times, most recently
from
8021c98 to
598bd8e
Compare
common/common-gpu.h
Outdated
|
|
||
| #pragma once | ||
| #include "daemon_config.h" | ||
| #define CONFIG_VALUE_MAX 256 |
There was a problem hiding this comment.
Why the duplicated definition?
There was a problem hiding this comment.
To split out the dependency between common and daemon code.
But yeah, it's a bit confusing now, I'll clean it up.
| */ | ||
| static GameModeClient *game_mode_client_new(pid_t pid, char *executable) | ||
| { | ||
| /* clang-format off */ |
There was a problem hiding this comment.
Why is this needed (and the other one)? These are in my preferred style already but is it not possible to get clang-format to do this?
There was a problem hiding this comment.
I'm not 100% sure why but on multiple different installs, clang reformats these two sections differently to the Travis instance the CI is running. I've tried to coax it into doing it correctly with options but nothing seems to work.
I'm put comments in 83e352b to explain. I think it's just a clang-format bug of some kind.
|
Added a couple of comments, and can you rebase on master since there are now conflicts? |
This is just additional code that isn't required, and could mask or cause problems.
Rename a bunch of files to make the consistent Create two new subdirectories for common code, and utilities
This groups development, daemon and lib parts together much better
mdiluz
force-pushed
the
the-big-cleanup
branch
2 times, most recently
from
0dbbc55 to
681c5b5
Compare
Leave a static assert to ensure they're in sync when relevant in gamemode-gpu
|
Rebased and addressed comments |
2 participants
