fix(micro): filter orphan 'bench:' lines before piping to benchmark-action#90
Merged
fix(micro): filter orphan 'bench:' lines before piping to benchmark-action#90
Conversation
…ction
Criterion's bencher-format output occasionally emits lines like
bench: 158,352 ns/iter (+/- 5,760)
without a preceding 'test <name> ...' prefix — benchmark-action/
github-action-benchmark blows up on those with exit 101 ('Error:
Invalid line'). Happens whenever criterion's group-ID formatting
interacts with pipe buffering.
Filter output.txt to only keep well-formed
'test <name> ... bench: N ns/iter (+/- M)' rows before the comparison
step reads it. The action doesn't use any other line types, so this
is lossless for our use.
Fixes the recurring red Micro Benchmarks check on every
FerrFlow-Org/FerrFlow PR.
1 task
BryanFRD
added a commit
that referenced
this pull request
Apr 22, 2026
…ction (#90) Criterion's bencher-format output occasionally emits lines like bench: 158,352 ns/iter (+/- 5,760) without a preceding 'test <name> ...' prefix — benchmark-action/ github-action-benchmark blows up on those with exit 101 ('Error: Invalid line'). Happens whenever criterion's group-ID formatting interacts with pipe buffering. Filter output.txt to only keep well-formed 'test <name> ... bench: N ns/iter (+/- M)' rows before the comparison step reads it. The action doesn't use any other line types, so this is lossless for our use. Fixes the recurring red Micro Benchmarks check on every FerrFlow-Org/FerrFlow PR.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Every FerrFlow PR has been failing `Micro Benchmarks` lately with exit 101. Root cause: criterion's `--output-format bencher` emits a handful of orphan lines:
```
bench: 158,352 ns/iter (+/- 5,760)
```
No `test ...` prefix. `benchmark-action/github-action-benchmark` sees them and panics on parse.
Fix
Filter `output.txt` to only the well-formed rows the action actually consumes:
```
grep -E '^test .+ ... bench:[[:space:]]+[0-9,]+ ns/iter' raw-output.txt > output.txt
```
Lossless — the comparison step reads no other line types.
Also prints the filtered output to the job log so the next time it goes sideways the raw vs filtered diff is inspectable.
Test plan