Closed
Conversation
|
|
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
|
|
Closed
This reverts commit ea8d756.
Author
|
Failing CI CI |
There was a problem hiding this comment.
Pull Request Overview
This PR unifies the packaging process by removing outdated documentation and updating the CI workflows for building Debian packages and Docker images.
- Removed the ferretdb_packaging/README.md to phase out legacy packaging instructions.
- Updated and enhanced the build workflow in .github/workflows/build_packages.yml, including changes to matrix configurations, version definition steps, and multi-job conditions.
Reviewed Changes
Copilot reviewed 2 out of 15 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| ferretdb_packaging/README.md | Removed obsolete build instructions for Debian packages. |
| .github/workflows/build_packages.yml | Updated workflow logic for building Debian packages and Docker images. |
Files not reviewed (13)
- .github/workflows/ferretdb_packages.yml: Language not supported
- ferretdb_packaging/Dockerfile_build_deb_packages: Language not supported
- ferretdb_packaging/build_packages.sh: Language not supported
- ferretdb_packaging/debian_files/changelog: Language not supported
- ferretdb_packaging/debian_files/compat: Language not supported
- ferretdb_packaging/debian_files/control: Language not supported
- ferretdb_packaging/debian_files/rules: Language not supported
- ferretdb_packaging/packaging-entrypoint.sh: Language not supported
- ferretdb_packaging/test_packages/Dockerfile_test_install_deb_packages: Language not supported
- ferretdb_packaging/test_packages/test-install-entrypoint.sh: Language not supported
- packaging/Dockerfile_build_deb_packages: Language not supported
- packaging/build_packages.sh: Language not supported
- packaging/debian_files/control: Language not supported
Comments suppressed due to low confidence (2)
.github/workflows/build_packages.yml:65
- Confirm that arm64 support is no longer required; if it is, consider adding it back to the matrix to support multi-architecture builds.
arch: [amd64]
.github/workflows/build_packages.yml:201
- Review if the lack of '-debian-only' flag in the docker job's Define version step is intentional or if it should be consistent with the deb package job.
go run ./defineversion -control-file ../pg_documentdb/documentdb.control -pg-version ${{ matrix.pg_version }}
noisersup
previously approved these changes
Apr 25, 2025
Closed
AlekSi
added
the
not ready
chilagrow
commented
Apr 29, 2025
| @@ -1,5 +1,5 @@ | |||
| ARG BASE_IMAGE=debian:bookworm | |||
| FROM ${BASE_IMAGE} | |||
| FROM --platform=linux/amd64 ${BASE_IMAGE} | |||
Author
There was a problem hiding this comment.
👀 looks like this is undesired accidental change.
|
@chilagrow this pull request has merge conflicts. |
Member
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes FerretDB/FerretDB#5052.
Packages / ...is fine because the file that triggers that workflow.github/workflows/ferretdb_packages.ymlis being removed in this PR.Build deb packages / ...should work.Don't enable auto merge please https://github.com/FerretDB/documentdb/pull/56/files#r2057555030