Explicitly use Platform Toolset v143 with vcpkg#67
Merged
Conversation
Contributor
Author
|
I force pushed to remove the added newlines on the vcxproj files because visual studio also removes a newline at end of file every time it writes them. |
Contributor
Author
|
I re-ran vcpkg without these changes so I can post the specific errors.
|
Fexty12573
approved these changes
May 22, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I'm not super familiar with Visual Studio, so I might be missing something, but this caused me a headache after installing VS 2022 and 2026 on the same machine. I was facing link errors that stemmed from dependencies compiled with different toolchain versions. From what I could deduce this should be what's necessary for opening the solution and building to "just work" if targeting an older Platform Toolset than the newest version installed on the system. There is a discussion about this problem here microsoft/vcpkg#25905. I don't think removing the x86 target is required but I figure it makes sense because we need the loader DLL to be x64 because the game exe is x64.