Skip to content

Conversation

@FidelusAleksander
Copy link
Owner

This pull request updates the GitHub Skills Dad Jokes action course to use a modern, bundled JavaScript action structure with improved, step-by-step instructions. The changes guide learners through setting up a cloud-based development environment, writing modular source files, bundling the action, defining metadata, and creating a workflow to run and consume the action output. The instructions are clearer, more practical, and aligned with current best practices for GitHub Actions.

Course Content and Instructional Improvements:

  • Step 1 (1-step.md): Rewritten to emphasize using GitHub Codespaces for setup, initializing the Node.js project, installing dependencies, and ensuring node_modules/ is excluded from version control.
  • Step 2 (2-step.md): Guides the learner to create modular source files (src/joke.js, src/main.js), run the action locally, and optionally debug using @github/local-action and VS Code launch configuration.

Action Packaging and Metadata:

  • Step 3 (3-step.md): Adds instructions to bundle the action using @vercel/ncc, updating package.json with a build script and generating a dist/index.js file for distribution.
  • Step 4 (4-step.md): Introduces creating a top-level action.yml referencing the bundled output, defining the action’s interface (name, description, outputs, runtime, main entry).

Workflow Integration:

  • Step 5 (5-step.md): Provides a workflow example that triggers on issue comments, runs the Dad Jokes action, and posts the joke as a comment using the output.

Cleanup and Minor Changes:

  • Removes unused or placeholder files (-step.txt, 0-welcome.md). [1] [2]

These updates make the course more engaging and practical, ensuring learners follow current standards for building, packaging, and using JavaScript GitHub Actions.

Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR modernizes the GitHub Skills Dad Jokes action course by transitioning from a local .github/actions/ structure to a bundled, top-level JavaScript action following current best practices. The updates provide clearer step-by-step instructions that guide learners through setting up a cloud-based development environment, writing modular source files, bundling with @vercel/ncc, defining action metadata, and creating a workflow that consumes action outputs.

  • Rewrites all step files to align with modern JavaScript action development patterns
  • Updates validation workflows to check for new file locations and bundled output
  • Removes unused placeholder files

Reviewed Changes

Copilot reviewed 16 out of 16 changed files in this pull request and generated 1 comment.

Show a summary per file
File Description
.github/workflows/my-workflow.yml Removes the old workflow template file
.github/workflows/6-step.yml Updates validation to check for successful Joke Action workflow run instead of label application
.github/workflows/5-step.yml Changes validation to check for joke-action.yml workflow file with issue_comment trigger and output reference
.github/workflows/4-step.yml Updates validation to check for top-level action.yml referencing dist/index.js and declaring joke output
.github/workflows/3-step.yml Changes validation to verify build script in package.json and bundled dist/index.js file
.github/workflows/2-step.yml Updates validation to check for src/main.js and src/joke.js source files
.github/workflows/1-step.yml Adds comprehensive checks for project initialization, dependencies, and .gitignore configuration
.github/workflows/0-start-exercise.yml Updates exercise-toolkit version reference
.github/steps/6-step.md Simplifies instructions to trigger action via issue comment
.github/steps/5-step.md Provides workflow example using issue_comment trigger and output consumption
.github/steps/4-step.md Streamlines instructions to create top-level action.yml metadata file
.github/steps/3-step.md Focuses on bundling action with @vercel/ncc
.github/steps/2-step.md Guides creation of modular source files with optional debugging setup
.github/steps/1-step.md Rewrites setup to use GitHub Codespaces and modern project initialization
.github/steps/0-welcome.md Removes unused placeholder file
.github/steps/-step.txt Removes unused placeholder file

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@FidelusAleksander FidelusAleksander merged commit a0259ea into main Nov 6, 2025
@FidelusAleksander FidelusAleksander deleted the step-cleanup branch November 6, 2025 18:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants