Consolidate sub/ path into one helper; fixes #921#923
Merged
Conversation
…#921) Three separate modules were computing the filesystem walk from the fido Python package back to the repo-root sub/ tree, each with its own stale copy of the pre-rename formula: - gh_status.py:18 parent.parent / "sub" → /workspace/src/sub ❌ - status.py:361 parents[1] / "sub" / "persona.md" ❌ - worker.py:197 parent.parent / "sub" → /workspace/src/sub ❌ - config.py:114 parents[2] / "sub" → fixed in #920 ✓ Only config.py got updated when the package moved from kennel/ to src/fido/. The other three kept pointing at the non-existent /workspace/src/sub/, which is how ClaudeSession ended up launching claude with --system-prompt-file /workspace/src/sub/persona.md and claude exited silently with "System prompt file not found" written to stderr — hidden behind the unread stderr pipe until the #922 stderr-drain made it visible. Adds fido.config.default_sub_dir() as the single source of truth and switches all four callers to use it. Inline computation of this path is now a review-time smell: grep for parents\[.\] / "sub" in any new PR and redirect it here.
rhencke
approved these changes
Apr 24, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #921.
Three separate modules (
gh_status.py,status.py,worker.py) still had their own pre-rename copies of the filesystem walk tosub/. Onlyconfig.pywas updated when the package moved fromkennel/tosrc/fido/(#920). The other three kept pointing at the non-existent/workspace/src/sub/, which is why ClaudeSession launched claude with--system-prompt-file /workspace/src/sub/persona.mdand claude exited silently with:That error was hidden behind an unread stderr pipe until #922 landed the stderr drain and made it visible. This PR fixes the actual crash by moving all four callers onto a single
fido.config.default_sub_dir()helper — inlineparents[N] / "sub"is now a review-time smell../fido cigreen.