-
Notifications
You must be signed in to change notification settings - Fork 81
Improve CI #199
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Improve CI #199
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,70 +1,38 @@ | ||
| name: Ubuntu CI | ||
|
|
||
| on: [pull_request] | ||
| on: | ||
| workflow_dispatch: | ||
| pull_request: | ||
|
|
||
| jobs: | ||
| Test-Focal-Noetic-Gazebo11: | ||
|
|
||
| jobs: | ||
| build-focal-noetic-gazebo11: | ||
| strategy: | ||
| matrix: | ||
| env: | ||
| - {ROS_DISTRO: noetic, ROS_REPO: main} | ||
|
|
||
| env: | ||
| UPSTREAM_WORKSPACE: extras/repos/dave_sim.repos | ||
| BASEDIR: ${{ github.workspace }}/.work | ||
| AFTER_SETUP_UPSTREAM_WORKSPACE: vcs pull $BASEDIR/upstream_ws/src | ||
| DOCKER_IMAGE: woensugchoi/dave:latest | ||
| TARGET_CMAKE_ARGS: > | ||
| -DCMAKE_EXE_LINKER_FLAGS=-fuse-ld=lld | ||
| -DCMAKE_SHARED_LINKER_FLAGS=-fuse-ld=lld | ||
| -DCMAKE_MODULE_LINKER_FLAGS=-fuse-ld=lld | ||
| -DCMAKE_BUILD_TYPE=Release | ||
| ADDITIONAL_DEBS: lld python3-catkin-tools python3-osrf-pycommon | ||
| runs-on: ubuntu-20.04 | ||
| container: | ||
| image: woensugchoi/dave:latest | ||
| steps: | ||
| - run: sudo chown -R `whoami`:`whoami` . | ||
| - uses: actions/checkout@v2 | ||
| - name: Install base dependencies | ||
| run: | | ||
| sudo apt update; | ||
| sudo apt-get -y install cppcheck protobuf-compiler; | ||
|
|
||
| - name: Static code checking | ||
| run: sh tools/code_check.sh | ||
|
|
||
| - name: Checkout ds_msgs | ||
| uses: actions/checkout@v2 | ||
| with: | ||
| repository: Field-Robotics-Lab/ds_msgs | ||
| path: ds_msgs | ||
|
|
||
| - name: Checkout ds_sim | ||
| uses: actions/checkout@v2 | ||
| with: | ||
| repository: Field-Robotics-Lab/ds_sim | ||
| path: ds_sim | ||
|
|
||
| - name: Checkout eca a9 | ||
| uses: actions/checkout@v2 | ||
| with: | ||
| repository: uuvsimulator/eca_a9 | ||
| path: eca_a9 | ||
|
|
||
| - name: Checkout rexrov2 | ||
| uses: actions/checkout@v2 | ||
| with: | ||
| repository: uuvsimulator/rexrov2 | ||
| path: rexrov2 | ||
|
|
||
| - name: Checkout uuv manipulators | ||
| uses: actions/checkout@v2 | ||
| with: | ||
| repository: Field-Robotics-Lab/uuv_manipulators | ||
| path: uuv_manipulators | ||
|
|
||
| - name: Checkout uuv simulator | ||
| uses: actions/checkout@v2 | ||
| with: | ||
| repository: Field-Robotics-Lab/uuv_simulator | ||
| path: uuv_simulator | ||
|
|
||
| - name: Set up workspace | ||
| run: | | ||
| mkdir -p /tmp/uuv_ws/src; | ||
| ln -s `pwd` /tmp/uuv_ws/src; | ||
|
|
||
|
|
||
| - name: Build and run tests | ||
| shell: bash | ||
| run: | | ||
| cd /tmp/uuv_ws; | ||
| source /opt/ros/noetic/setup.bash; | ||
| catkin_make -j1; | ||
| catkin_make run_tests -j1; | ||
| steps: | ||
| - uses: actions/checkout@v2 | ||
| - name: Prepare | ||
| run: | | ||
| sudo apt update; | ||
| sudo apt-get -y install cppcheck protobuf-compiler; | ||
| sed -i "s/git@github.com:/https:\/\/github.com\//g" extras/repos/dave_sim.repos | ||
| - name: Static code checking | ||
| run: sh tools/code_check.sh | ||
| - uses: 'ros-industrial/industrial_ci@master' | ||
| env: ${{ matrix.env }} |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@senceryazici What does this addition do?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Since it is definitely harmless, I'm going to go ahead and merge, but if you can explain I'd appreciate it.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
While testing on my local with 'act' (a tool for running GitHub actions on your local) the code check script constantly failed for some reason. Just for debugging I added a line to the end to see the result and it started passing.
Honestly (just like you've said) since it's totally harmless I didn't spend extra time on it's reason and let it be that way. But I'll definitely take a look at it when I have available time.