[43991] add rollback to pipelines #39
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nrutman
reviewed
Oct 4, 2024
Contributor
nrutman
left a comment
nrutman
left a comment
There was a problem hiding this comment.
This is looking REALLY good. I added two small commits:
One commit simplifies some type names and the tests that go with the rollback functionality.
The other commit tests errors in the rollbacks specifically and adds an additional error class for these types of errors.
I'm leaving this review as a comment until I can get someone to review my commits.
jazanne
approved these changes
Oct 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ticket: https://app.shortcut.com/fieldguide/story/43991/add-rollback-to-pipelines
Add new stage type that has a
rollbackfunction to undo changes made during that stage.Bumped the version a minor version to 0.1.0 (no breaking changes introduced).