docs: clarify provenance (original work developed in turbovec, not extracted source)#5
Conversation
…xtracted source Codex stop-gate review flagged a license/provenance mismatch: LICENSE-MIT credits only Nelson Spence, but lib.rs/README said the substrate was 'extracted from turbovec', implying it is turbovec's MIT source (which would require preserving the upstream copyright notice). Authorship is 42/42 Nelson Spence across all 4,664 source lines, with none of turbovec's own source included — the rank/sign substrate is original work developed within the turbovec project and factored out here. Reword the provenance to say exactly that, keep a courtesy acknowledgment of turbovec / Ryan Codrai, and retain the Nelson Spence copyright (now consistent with the provenance).
Review Summary by QodoClarify provenance: original substrate developed in turbovec, not extracted
WalkthroughsDescription• Clarify provenance: substrate is original work developed within turbovec, not extracted source • Update lib.rs documentation to accurately reflect authorship and factoring process • Revise README provenance section with detailed attribution and acknowledgment • Resolve license/provenance mismatch flagged by Codex review Diagramflowchart LR
A["Provenance Mismatch<br/>LICENSE-MIT vs lib.rs/README"] -->|"Clarify wording"| B["Original Work<br/>Developed in turbovec"]
B -->|"Update documentation"| C["lib.rs & README<br/>Accurate Attribution"]
C -->|"Result"| D["Consistent License<br/>& Provenance"]
File Changes1. src/lib.rs
|
Code Review by Qodo
1.
|
There was a problem hiding this comment.
Code Review
This pull request updates the provenance and description of the ordvec crate in README.md and src/lib.rs to clarify its relationship with the turbovec project. A review comment suggests refining the README text for consistency with the library documentation by using the term 'substrate' and including the 'training-free' descriptor.
The previous 'includes none of turbovec's own source' contradicted the 'ported/extracted from turbovec' notes in fastscan.rs, the fastscan test, and the four redteam suites. All of that is original work (42/42 commits are Nelson Spence) that lived in the turbovec repo and was ported/factored out, so the absolute claim was both inconsistent and beside the point. Reword to 'original ordinal/sign retrieval substrate developed within the turbovec project ... factored out' — consistent with the porting notes, keeps the turbovec credit, and 'code' -> 'substrate' for consistency with src/lib.rs (gemini).
Provenance fix (Codex stop-gate review)
Codex flagged a license/provenance mismatch:
LICENSE-MITcredits only Nelson Spence, butlib.rs/READMEsaid the substrate was "extracted from turbovec (MIT)" — wording that implies it is turbovec's MIT source (which would require preserving the upstream copyright notice).The wording was the only thing wrong. Authorship is 42/42 commits Nelson Spence, all 4,664 source lines blame to him, and none of turbovec's own source was taken (only the rank/sign substrate;
SearchResultswas redefined fresh; no TurboQuant code). The substrate is original work that was developed within the turbovec project and factored out — not extracted from turbovec's code.Change
lib.rs+README: "extracted from turbovec" → "original … substrate, developed within the turbovec project (MIT, by Ryan Codrai) and factored out as a standalone crate … includes none of turbovec's own source."LICENSE-MIT(Nelson Spence) unchanged — now consistent with the provenance.Resolves the mismatch per the "your copyright + credit turbovec" decision.