Skip to content

docs: clarify provenance (original work developed in turbovec, not extracted source)#5

Merged
Fieldnote-Echo merged 2 commits into
mainfrom
prod/license-fix
May 23, 2026
Merged

docs: clarify provenance (original work developed in turbovec, not extracted source)#5
Fieldnote-Echo merged 2 commits into
mainfrom
prod/license-fix

Conversation

@Fieldnote-Echo
Copy link
Copy Markdown
Owner

Provenance fix (Codex stop-gate review)

Codex flagged a license/provenance mismatch: LICENSE-MIT credits only Nelson Spence, but lib.rs/README said the substrate was "extracted from turbovec (MIT)" — wording that implies it is turbovec's MIT source (which would require preserving the upstream copyright notice).

The wording was the only thing wrong. Authorship is 42/42 commits Nelson Spence, all 4,664 source lines blame to him, and none of turbovec's own source was taken (only the rank/sign substrate; SearchResults was redefined fresh; no TurboQuant code). The substrate is original work that was developed within the turbovec project and factored out — not extracted from turbovec's code.

Change

  • lib.rs + README: "extracted from turbovec""original … substrate, developed within the turbovec project (MIT, by Ryan Codrai) and factored out as a standalone crate … includes none of turbovec's own source."
  • Keeps a clear courtesy acknowledgment of turbovec / Ryan Codrai as the origin project.
  • LICENSE-MIT (Nelson Spence) unchanged — now consistent with the provenance.

Resolves the mismatch per the "your copyright + credit turbovec" decision.

…xtracted source

Codex stop-gate review flagged a license/provenance mismatch: LICENSE-MIT
credits only Nelson Spence, but lib.rs/README said the substrate was
'extracted from turbovec', implying it is turbovec's MIT source (which would
require preserving the upstream copyright notice). Authorship is 42/42 Nelson
Spence across all 4,664 source lines, with none of turbovec's own source
included — the rank/sign substrate is original work developed within the
turbovec project and factored out here. Reword the provenance to say exactly
that, keep a courtesy acknowledgment of turbovec / Ryan Codrai, and retain the
Nelson Spence copyright (now consistent with the provenance).
@qodo-code-review
Copy link
Copy Markdown

Review Summary by Qodo

Clarify provenance: original substrate developed in turbovec, not extracted

📝 Documentation

Grey Divider

Walkthroughs

Description
• Clarify provenance: substrate is original work developed within turbovec, not extracted source
• Update lib.rs documentation to accurately reflect authorship and factoring process
• Revise README provenance section with detailed attribution and acknowledgment
• Resolve license/provenance mismatch flagged by Codex review
Diagram
flowchart LR
  A["Provenance Mismatch<br/>LICENSE-MIT vs lib.rs/README"] -->|"Clarify wording"| B["Original Work<br/>Developed in turbovec"]
  B -->|"Update documentation"| C["lib.rs & README<br/>Accurate Attribution"]
  C -->|"Result"| D["Consistent License<br/>& Provenance"]

Loading

File Changes

1. src/lib.rs 📝 Documentation +4/-2

Clarify substrate origin and turbovec attribution

• Changed "extracted from turbovec" to "original training-free ordinal/sign retrieval substrate,
 developed within the turbovec project"
• Added explicit credit to Ryan Codrai and turbovec project
• Clarified that the substrate was factored out as a standalone crate
• Maintained courtesy acknowledgment while correcting the provenance wording

src/lib.rs


2. README.md 📝 Documentation +7/-4

Expand provenance section with detailed attribution

• Replaced "Extracted from turbovec" with "original ordinal/sign retrieval code, developed within
 the turbovec project"
• Added explicit mention that it includes none of turbovec's own source, only the rank/sign
 substrate
• Expanded attribution to include Ryan Codrai and MIT license reference
• Added gratitude statement acknowledging turbovec as the origin project
• Preserved note about full development history in git log

README.md


Grey Divider

Qodo Logo

@qodo-code-review
Copy link
Copy Markdown

qodo-code-review Bot commented May 22, 2026

Code Review by Qodo

🐞 Bugs (0) 📘 Rule violations (0) 📎 Requirement gaps (0)

Grey Divider


Action required

1. Provenance claim contradicts repo ✓ Resolved 🐞 Bug ≡ Correctness
Description
README.md now states the crate includes none of turbovec’s source, but other tracked source files
explicitly say code/tests were extracted/ported verbatim from turbovec. This makes the updated
provenance statement internally inconsistent and reintroduces the same provenance/licensing
confusion this PR is trying to eliminate.
Code

README.md[R26-32]

Evidence
The PR introduces an absolute statement that no turbovec source is included, but multiple repository
files explicitly claim extraction/porting from turbovec. These statements cannot all be true at the
same time, so the new provenance text is internally inconsistent with the repository contents.

README.md[24-32]
src/lib.rs[1-8]
benchmarks/rank_modes_results.txt[1-12]
src/rank_index/fastscan.rs[25-39]
tests/redteam_alpha.rs[1-8]
tests/redteam_beta.rs[1-7]
tests/redteam_delta.rs[1-8]

Agent prompt
The issue below was found during a code review. Follow the provided context and guidance below and implement a solution

## Issue description
README.md (and the crate-level docs) now assert ordvec “includes none of turbovec's own source,” but other files in this repository explicitly document that parts were extracted/ported from turbovec (including “ported verbatim” test suites and a “ported from turbovec” module provenance block). This contradiction is likely to keep triggering automated provenance/license checks and misleads readers.

## Issue Context
You can resolve this either by (a) softening/qualifying the new README/lib.rs claims to match reality (e.g., clarify that core substrate was developed in turbovec and factored out, while some modules/tests are ported), or (b) updating/removing the “ported/extracted from turbovec” statements elsewhere if they are no longer accurate.

## Fix Focus Areas
- README.md[24-32]
- src/lib.rs[1-8]
- benchmarks/rank_modes_results.txt[1-12]
- src/rank_index/fastscan.rs[25-39]
- tests/redteam_alpha.rs[1-8]
- tests/redteam_beta.rs[1-7]
- tests/redteam_delta.rs[1-8]

ⓘ Copy this prompt and use it to remediate the issue with your preferred AI generation tools


Grey Divider

Qodo Logo

Copy link
Copy Markdown

@gemini-code-assist gemini-code-assist Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request updates the provenance and description of the ordvec crate in README.md and src/lib.rs to clarify its relationship with the turbovec project. A review comment suggests refining the README text for consistency with the library documentation by using the term 'substrate' and including the 'training-free' descriptor.

Comment thread README.md Outdated
Comment thread README.md Outdated
The previous 'includes none of turbovec's own source' contradicted the
'ported/extracted from turbovec' notes in fastscan.rs, the fastscan test, and
the four redteam suites. All of that is original work (42/42 commits are Nelson
Spence) that lived in the turbovec repo and was ported/factored out, so the
absolute claim was both inconsistent and beside the point. Reword to 'original
ordinal/sign retrieval substrate developed within the turbovec project ...
factored out' — consistent with the porting notes, keeps the turbovec credit,
and 'code' -> 'substrate' for consistency with src/lib.rs (gemini).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant