Skip to content
This repository was archived by the owner on Aug 29, 2023. It is now read-only.

Update dependency tornado from 6.3.2 to 6.3.3 [SECURITY]#48

Merged
wbaker-figure merged 1 commit intomainfrom
renovate/pypi-tornado-vulnerability
Aug 16, 2023
Merged

Update dependency tornado from 6.3.2 to 6.3.3 [SECURITY]#48
wbaker-figure merged 1 commit intomainfrom
renovate/pypi-tornado-vulnerability

Conversation

@figure-renovate
Copy link
Copy Markdown
Contributor

This PR contains the following updates:

Package Change Age Adoption Passing Confidence
tornado (source) ==6.3.2 -> ==6.3.3 age adoption passing confidence

GitHub Vulnerability Alerts

GHSA-qppv-j76h-2rpx

Summary

Tornado interprets -, +, and _ in chunk length and Content-Length values, which are not allowed by the HTTP RFCs. This can result in request smuggling when Tornado is deployed behind certain proxies that interpret those non-standard characters differently. This is known to apply to older versions of haproxy, although the current release is not affected.

Details

Tornado uses the int constructor to parse the values of Content-Length headers and chunk lengths in the following locations:

tornado/http1connection.py:445

            self._expected_content_remaining = int(headers["Content-Length"])

tornado/http1connection.py:621

                content_length = int(headers["Content-Length"])  # type: Optional[int]

tornado/http1connection.py:671

            chunk_len = int(chunk_len_str.strip(), 16)

Because int("0_0") == int("+0") == int("-0") == int("0"), using the int constructor to parse and validate strings that should contain only ASCII digits is not a good strategy.


Release Notes

tornadoweb/tornado

v6.3.3

Compare Source


Configuration

📅 Schedule: Branch creation - "" (UTC), Automerge - At any time (no schedule defined).

🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.

Rebasing: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.

🔕 Ignore: Close this PR and you won't be reminded about this update again.


  • If you want to rebase/retry this PR, check this box

@figure-renovate figure-renovate bot requested a review from a team August 15, 2023 03:59
@wbaker-figure wbaker-figure merged commit f14a498 into main Aug 16, 2023
@wbaker-figure wbaker-figure deleted the renovate/pypi-tornado-vulnerability branch August 16, 2023 14:43
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant