Skip to content

remove signer-provenance#67

Merged
benarena merged 1 commit intomainfrom
benarena/remove-wallet-signer
Sep 28, 2023
Merged

remove signer-provenance#67
benarena merged 1 commit intomainfrom
benarena/remove-wallet-signer

Conversation

@benarena
Copy link
Copy Markdown
Contributor

This implementation was originally created when the pb-grpc-client-kotlin implementation used the provenance hdwallet libraries. The provenance version has since been updated to match this implementation's use of hdwallet libraries, thus making this implementation redundant.

I've removed all uses of this signer:
https://github.com/FigureTechnologies/provenance-service-marketpalace/pull/2741
https://github.com/FigureTechnologies/service-universal-passport/pull/420

Uses:
https://github.com/search?q=org%3AFigureTechnologies%20signer-provenance&type=code

Copy link
Copy Markdown
Contributor

@mwoods-figure mwoods-figure left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 If aprovenance-service-marketpalace and service-universal-passport are the only uses of it, then a removal is probably fine, otherwise I'd suggest a patch release with a @Deprecated warning, followed by a minor release with the actual removal.

@benarena
Copy link
Copy Markdown
Contributor Author

👍 If aprovenance-service-marketpalace and service-universal-passport are the only uses of it, then a removal is probably fine, otherwise I'd suggest a patch release with a @Deprecated warning, followed by a minor release with the actual removal.

I agree with this approach, but it is only these two services so I was going to skip a step. Definitely open to deprecating first if anyone feels it worth the effort, though given the use cases of this library (almost entirely through figure version catalogs) I expect that the intermediate step won't actually have an impact. I do suggest at least a minor release, however.

@benarena benarena merged commit 26871a2 into main Sep 28, 2023
@benarena benarena deleted the benarena/remove-wallet-signer branch September 28, 2023 17:42
@benarena benarena added the enhancement New feature or request label Sep 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants