Conversation
mwoods-figure
left a comment
There was a problem hiding this comment.
👍 If aprovenance-service-marketpalace and service-universal-passport are the only uses of it, then a removal is probably fine, otherwise I'd suggest a patch release with a @Deprecated warning, followed by a minor release with the actual removal.
I agree with this approach, but it is only these two services so I was going to skip a step. Definitely open to deprecating first if anyone feels it worth the effort, though given the use cases of this library (almost entirely through figure version catalogs) I expect that the intermediate step won't actually have an impact. I do suggest at least a minor release, however. |
This implementation was originally created when the pb-grpc-client-kotlin implementation used the provenance hdwallet libraries. The provenance version has since been updated to match this implementation's use of hdwallet libraries, thus making this implementation redundant.
I've removed all uses of this signer:
https://github.com/FigureTechnologies/provenance-service-marketpalace/pull/2741
https://github.com/FigureTechnologies/service-universal-passport/pull/420
Uses:
https://github.com/search?q=org%3AFigureTechnologies%20signer-provenance&type=code