fix(backend): negative avg time to retrieve metrics#140
Merged
silent-cipher merged 5 commits intomainfrom Jan 23, 2026
Merged
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Contributor
There was a problem hiding this comment.
Pull request overview
This PR fixes an issue with negative average time-to-retrieve metrics in the IPNI monitoring system. The fix prevents negative durations by using Math.max(0, ...), handles missing uploadEndTime by skipping metric calculations, and provides a fallback timestamp when the SDK doesn't return retrievedAt.
Changes:
- Modified uploadEndTime handling to skip duration calculations when the value is missing instead of defaulting to current time
- Added Math.max(0, ...) safeguard to prevent negative durations from clock skew
- Implemented fallback logic for missing retrievedAt timestamps from the SDK
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
SgtPooki
reviewed
Jan 21, 2026
Collaborator
SgtPooki
left a comment
SgtPooki
left a comment
There was a problem hiding this comment.
some comments about consistency and goals of the metric..
SgtPooki
approved these changes
Jan 22, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR includes -
uploadEndTimetonow. If it is missing, we simply skip the duration calculation (metrics are meaningless without a valid start time).Math.max(0, ...)to ensure that even with slight clock skews, we never record negative durations.retrievedAtis missing from sdk, fallback to time when dealbot catches status change toretrievedCloses #63