fix: remove RETRIEVAL_TIMEOUT_BUFFER_MS#266
Merged
Conversation
BigLep
requested review from
Copilot and
silent-cipher
and removed request for
silent-cipher
Contributor
There was a problem hiding this comment.
Pull request overview
Removes the now-unneeded RETRIEVAL_TIMEOUT_BUFFER_MS configuration path, relying on pg-boss job timeouts and end-to-end abort-signal propagation for retrieval cancellation.
Changes:
- Removed
RETRIEVAL_TIMEOUT_BUFFER_MSfrom config schema/loading and from documented environment variables. - Simplified retrieval scheduling/execution to stop computing “interval minus buffer” time budgets and removed the batch/deal-level timeout plumbing in retrieval flows.
- Updated retrieval/job unit tests to reflect abort-signal-driven cancellation behavior.
Reviewed changes
Copilot reviewed 8 out of 8 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
| docs/environment-variables.md | Removes RETRIEVAL_TIMEOUT_BUFFER_MS docs and related constraints/notes. |
| apps/backend/src/config/app.config.ts | Drops env var from Joi schema + config types/loading; adjusts retrieval interval validation. |
| apps/backend/.env.example | Removes RETRIEVAL_TIMEOUT_BUFFER_MS from backend env template. |
| apps/backend/src/scheduler/scheduler.service.ts | Removes per-run computed timeout and passes only AbortSignal into retrieval batch runs. |
| apps/backend/src/retrieval/retrieval.service.ts | Removes timeout params/logic (including withTimeout) and relies on abort propagation. |
| apps/backend/src/retrieval/retrieval.service.spec.ts | Updates tests away from timeout/deadline behavior toward abort-driven behavior. |
| apps/backend/src/jobs/jobs.service.ts | Removes interval/buffer timeout calculation for retrieval jobs; relies on job-level abort timeout. |
| apps/backend/src/jobs/jobs.service.spec.ts | Updates mocked retrieval API signature to match removal of timeout arg. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
github-project-automation
Bot
moved this from 🔎 Awaiting review
to ✔️ Approved by reviewer
in FOC
Base automatically changed from
258-we-need-to-set-dealretrieval-max-timeout
to
main
February 16, 2026 12:58
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
built on top of #263.
we no longer need the RETRIEVAL_TIMEOUT_BUFFER_MS with pgboss workers and retrieval's handling abort signals.