Feat: use sdk's next version#3
Merged
silent-cipher merged 5 commits intomainfrom Aug 28, 2025
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR modernizes the codebase by upgrading to Synapse SDK's next version and converting the project to use ES modules. The changes include automatic wallet management for storage payments, integration with Kaggle datasets, and updates to deal creation workflow to accommodate SDK changes.
Key changes:
- Conversion to ES modules with
.jsfile extensions in imports - Upgrade to Synapse SDK v0.24.0-dev1 with updated API calls
- Addition of automatic wallet funding and service approval functionality
Reviewed Changes
Copilot reviewed 38 out of 39 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
| package.json | Updates SDK version and enables ES module support |
| src/scheduler/scheduler.service.ts | Adds wallet management logic for automatic deposits and approvals |
| src/deal/deal.service.ts | Updates deal creation to use new SDK APIs and Kaggle data source |
| src/dataSource/dataSource.service.ts | Implements Kaggle dataset fetching with fallback to local datasets |
| Multiple module files | Converts all imports to use .js extensions for ES module compatibility |
Files not reviewed (1)
- pnpm-lock.yaml: Language not supported
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
| } | ||
|
|
||
| return buffer; | ||
| throw new Error(`Failed to construct kaggle dataset download url for dataset ${dataset.ref}`); |
There was a problem hiding this comment.
The error message should provide more context about why the URL construction failed, such as mentioning missing required fields or invalid dataset structure.
Suggested change
| throw new Error(`Failed to construct kaggle dataset download url for dataset ${dataset.ref}`); | |
| throw new Error( | |
| `Failed to construct kaggle dataset download url. ` + | |
| `Dataset details: ref=${JSON.stringify(dataset.ref)}, ` + | |
| `url=${JSON.stringify(dataset.url)}, ` + | |
| `urlNullable=${JSON.stringify(dataset.urlNullable)}, ` + | |
| `hasUrl=${JSON.stringify(dataset.hasUrl)}. ` + | |
| `Possible reasons: missing or invalid 'ref', 'url', or 'urlNullable' fields.` | |
| ); |
This was referenced Apr 27, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Includes -