Skip to content

Feat: use sdk's next version#3

Merged
silent-cipher merged 5 commits intomainfrom
feat/next-sdk-version
Aug 28, 2025
Merged

Feat: use sdk's next version#3
silent-cipher merged 5 commits intomainfrom
feat/next-sdk-version

Conversation

@silent-cipher
Copy link
Copy Markdown
Collaborator

Includes -

  • conversion to 'module'
  • random dataset from kaggle
  • automatic deposit and approvals to payment contracts for warm storage service
  • use of sdk's next version ( renames & commpV2 )

@FilOzzy FilOzzy added this to FOC Aug 21, 2025
@github-project-automation github-project-automation Bot moved this to 📌 Triage in FOC Aug 21, 2025
@BigLep BigLep moved this from 📌 Triage to 🔎 Awaiting review in FOC Aug 22, 2025
@BigLep BigLep requested a review from Copilot August 22, 2025 03:36
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR modernizes the codebase by upgrading to Synapse SDK's next version and converting the project to use ES modules. The changes include automatic wallet management for storage payments, integration with Kaggle datasets, and updates to deal creation workflow to accommodate SDK changes.

Key changes:

  • Conversion to ES modules with .js file extensions in imports
  • Upgrade to Synapse SDK v0.24.0-dev1 with updated API calls
  • Addition of automatic wallet funding and service approval functionality

Reviewed Changes

Copilot reviewed 38 out of 39 changed files in this pull request and generated 3 comments.

Show a summary per file
File Description
package.json Updates SDK version and enables ES module support
src/scheduler/scheduler.service.ts Adds wallet management logic for automatic deposits and approvals
src/deal/deal.service.ts Updates deal creation to use new SDK APIs and Kaggle data source
src/dataSource/dataSource.service.ts Implements Kaggle dataset fetching with fallback to local datasets
Multiple module files Converts all imports to use .js extensions for ES module compatibility
Files not reviewed (1)
  • pnpm-lock.yaml: Language not supported

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

Comment thread src/scheduler/scheduler.service.ts Outdated
}

return buffer;
throw new Error(`Failed to construct kaggle dataset download url for dataset ${dataset.ref}`);
Copy link

Copilot AI Aug 22, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The error message should provide more context about why the URL construction failed, such as mentioning missing required fields or invalid dataset structure.

Suggested change
throw new Error(`Failed to construct kaggle dataset download url for dataset ${dataset.ref}`);
throw new Error(
`Failed to construct kaggle dataset download url. ` +
`Dataset details: ref=${JSON.stringify(dataset.ref)}, ` +
`url=${JSON.stringify(dataset.url)}, ` +
`urlNullable=${JSON.stringify(dataset.urlNullable)}, ` +
`hasUrl=${JSON.stringify(dataset.hasUrl)}. ` +
`Possible reasons: missing or invalid 'ref', 'url', or 'urlNullable' fields.`
);

Copilot uses AI. Check for mistakes.
Comment thread src/scheduler/scheduler.service.ts Outdated
@silent-cipher silent-cipher merged commit 1a98708 into main Aug 28, 2025
@github-project-automation github-project-automation Bot moved this from 🔎 Awaiting review to 🎉 Done in FOC Aug 28, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: 🎉 Done

Development

Successfully merging this pull request may close these issues.

5 participants