feat: upgrade sdk version to 0.24.1#6
Merged
silent-cipher merged 4 commits intomainfrom Sep 7, 2025
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull Request Overview
Upgrades the Synapse SDK from version 0.24.0-dev1 to 0.24.1, introducing significant API changes including the use of the Synapse factory pattern and updated provider information structure.
- Migrates to new SDK API with Synapse factory and async service initialization
- Updates provider data structure from ApprovedProviderInfo to ProviderInfo with nested product information
- Adds configuration option for dataset creation fee checking
Reviewed Changes
Copilot reviewed 10 out of 11 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| package.json | Updates SDK version to 0.24.1 |
| src/wallet-sdk/wallet-sdk.service.ts | Refactors service initialization to use Synapse factory and new provider APIs |
| src/scheduler/scheduler.service.ts | Adds provider count validation before operations |
| src/retrieval/retrieval.service.ts | Updates provider service URL access to use nested product structure |
| src/infrastructure/database/entities/storage-provider.entity.ts | Adds new provider metadata fields |
| src/domain/interfaces/external-services.interface.ts | Updates type imports to use ProviderInfo |
| src/domain/entities/storage-provider.entity.ts | Adds new provider metadata properties |
| src/deal/deal.service.ts | Updates provider handling and service URL access patterns |
| src/config/app.config.ts | Adds dataset creation fee configuration option |
| .env.example | Documents new configuration variable |
Files not reviewed (1)
- pnpm-lock.yaml: Language not supported
Comments suppressed due to low confidence (1)
src/retrieval/retrieval.service.ts:1
- Using non-null assertion operator (!) without proper null checking is risky. Consider adding a null check before pushing to the array or handling the case where getProvider returns null.
import { Injectable, Inject, Logger } from "@nestjs/common";
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
0a14de2 to
7d82a18
Compare
4 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.