Skip to content

feat: get PieceId from PieceCid#250

Merged
rvagg merged 11 commits intoFilOzone:mainfrom
akronim26:get_pieceId
Mar 12, 2026
Merged

feat: get PieceId from PieceCid#250
rvagg merged 11 commits intoFilOzone:mainfrom
akronim26:get_pieceId

Conversation

@akronim26
Copy link
Copy Markdown
Contributor

This resolves #247

@rvagg
Copy link
Copy Markdown
Contributor

rvagg commented Mar 9, 2026

@akronim26 check the diff, you've inlcuded a few unrelated changes in here that are just formatting, and CI is complaining about it. Try to keep the blast-radius of your PRs minimal to avoid linting problems and to make the review process a bit smoother. Thanks for the change though, it otherwise looks good 👌 .

@akronim26
Copy link
Copy Markdown
Contributor Author

Hey @rvagg, the lint check is failing due to a part which should not be concerned for this issue. Correct me if I'm wrong thou

@rvagg
Copy link
Copy Markdown
Contributor

rvagg commented Mar 10, 2026

@akronim26 yeah, I think I agree. It's a view function, and the optimisation buys us very little (loading to memory from calldata, it has to be done even in inline assembly but it might save a couple of ops to inline it, not enough to make this function messier IMO). For now, let's just put "asm-keccak256" in foundry.toml's exclude_lints, add a trailing comment: # flagging on a view function; revisit when forge supports inline suppression

Copy link
Copy Markdown
Contributor

@rvagg rvagg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

awesome, good job @akronim26

Comment thread test/PDPVerifier.t.sol Outdated
@rvagg rvagg merged commit f7487d5 into FilOzone:main Mar 12, 2026
3 checks passed
@github-project-automation github-project-automation bot moved this to 🎉 Done in PDP Mar 12, 2026
@BigLep BigLep added this to FOC Mar 13, 2026
@github-project-automation github-project-automation bot moved this from 📌 Triage to 🎉 Done in FOC Mar 13, 2026
@github-project-automation github-project-automation bot moved this to 📌 Triage in FOC Mar 13, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: 🎉 Done
Status: 🎉 Done

Development

Successfully merging this pull request may close these issues.

Efficient method to get pieceId from pieceCid

3 participants