feat: enforce additive-only storage layout changes for PDPVerifier#263
Conversation
cd8e935 to
4f8bf8c
Compare
- Update Makefile 'check-layout' to regenerate layouts and enforce git diff check - Restructure check_storage_layout.sh CI fallback to strictly fail - Transition script to use precise JSON metadata layout validation - Ensure 'fetch-depth: 0' in Github Actions for full historical diffing - Auto-generate PDPVerifierLayout.json snapshot
|
@Chaitu-Tatipamula I pushed a small follow-up to tighten the storage-layout guardrail in 38f3a76. The previous snapshot generation was flattening This change updates the generated |
cool Thanks @rjan90 |
Summary
Implements storage slot safety for the PDPVerifier upgradable contract
by enforcing that storage layout changes are strictly additive,
preventing storage collision bugs during contract upgrades.
Resolves #258
What's Checked
Changes
PDPVerifierLayout.solfrom contract source usingforge inspectchanges only add new slots at the end; flags destructive changes like
removed slots, moved slots, or inserted slots
(must be committed and kept in sync)
gen,check-layout,clean-gentargets formanaging storage layout
verify storage layout on all pushes/PRs
existing CI
Usage