fix: pieceStatus confuses piece ownership. Closes #296#655
Merged
hugomrdias merged 23 commits intomasterfrom Mar 12, 2026
Merged
fix: pieceStatus confuses piece ownership. Closes #296#655hugomrdias merged 23 commits intomasterfrom
hugomrdias merged 23 commits intomasterfrom
Conversation
Deploying with
|
| Status | Name | Latest Commit | Preview URL | Updated (UTC) |
|---|---|---|---|---|
| ✅ Deployment successful! View logs |
synapse-dev | b11ef4f | Commit Preview URL Branch Preview URL |
Mar 12 2026, 06:25 AM |
juliangruber
commented
Mar 6, 2026
rvagg
reviewed
Mar 9, 2026
packages/synapse-core/src/pdp-verifier/get-next-challenge-epoch.ts
Outdated
Show resolved
Hide resolved
Co-authored-by: Rod Vagg <rod@vagg.org>
Contributor
|
What are the next steps here for landing? |
Member
Author
I need to remove SP calls, so that this just checks contract state, then request review again |
rjan90
changed the title
rvagg
reviewed
Mar 11, 2026
rvagg
reviewed
Mar 11, 2026
packages/synapse-core/src/pdp-verifier/get-next-challenge-epoch.ts
Outdated
Show resolved
Hide resolved
rvagg
reviewed
Mar 11, 2026
packages/synapse-core/src/pdp-verifier/get-next-challenge-epoch.ts
Outdated
Show resolved
Hide resolved
Co-authored-by: Rod Vagg <rod@vagg.org>
…h.ts Co-authored-by: Rod Vagg <rod@vagg.org>
Contributor
|
2026-03-11 standup: @hugomrdias said he'll look today. |
hugomrdias
reviewed
Mar 11, 2026
| // Process proof timing data if we have data set data and PDP config | ||
| if (pdpConfig != null) { | ||
| // Check if this PieceCID is in the data set | ||
| const pieceData = activePieces.pieces.find((piece) => piece.cid.equals(parsedPieceCID)) |
Member
There was a problem hiding this comment.
do we need to find again? already done in line 1131
Member
Author
There was a problem hiding this comment.
good call, nice simplification
| // Check if this PieceCID is in the data set | ||
| const pieceData = activePieces.pieces.find((piece) => piece.cid.equals(parsedPieceCID)) | ||
|
|
||
| if (pieceData != null) { |
Member
There was a problem hiding this comment.
this should always be != null here if we take my previous comment
hugomrdias
approved these changes
Mar 12, 2026
github-project-automation
bot
moved this from ⌨️ In Progress
to ✔️ Approved by reviewer
in FOC
This was referenced Mar 12, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes that
pieceStatus()can say a piece was found when it was on the SP but not in the right data set.Closes #296.
TODO: