Skip to content

PelEntryTime is not bijective#32

Merged
mondrake merged 5 commits intomasterfrom
dev-0108
Jan 8, 2025
Merged

PelEntryTime is not bijective#32
mondrake merged 5 commits intomasterfrom
dev-0108

Conversation

@mondrake
Copy link

@mondrake mondrake commented Jan 8, 2025

Since #31, strict typing made so that timestamps are saved as strings in the object structure, but when saving a file it is expected they are ints, so the save fails.

@codecov
Copy link

codecov bot commented Jan 8, 2025

Codecov Report

Attention: Patch coverage is 50.00000% with 6 lines in your changes missing coverage. Please review.

Project coverage is 84.68%. Comparing base (71bc738) to head (f19b626).
Report is 1 commits behind head on master.

Files with missing lines Patch % Lines
src/PelEntryTime.php 50.00% 6 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##             master      #32      +/-   ##
============================================
+ Coverage     83.90%   84.68%   +0.77%     
  Complexity      625      625              
============================================
  Files            39       39              
  Lines          1491     1495       +4     
============================================
+ Hits           1251     1266      +15     
+ Misses          240      229      -11     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@mondrake mondrake changed the title Some types are too tight PelEntryTime is not bijective Jan 8, 2025
@mondrake mondrake merged commit 1a457a0 into master Jan 8, 2025
5 checks passed
@mondrake mondrake deleted the dev-0108 branch January 8, 2025 20:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant